* [tip: core/rcu] rcu: Clarify comments about FQS loop reporting quiescent states
@ 2020-10-09 6:35 tip-bot2 for Joel Fernandes (Google)
0 siblings, 0 replies; only message in thread
From: tip-bot2 for Joel Fernandes (Google) @ 2020-10-09 6:35 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Joel Fernandes (Google), Paul E. McKenney, x86, LKML
The following commit has been merged into the core/rcu branch of tip:
Commit-ID: f37599e6f06da47e49c3408afe66c5b6e83a90bd
Gitweb: https://git.kernel.org/tip/f37599e6f06da47e49c3408afe66c5b6e83a90bd
Author: Joel Fernandes (Google) <joel@joelfernandes.org>
AuthorDate: Fri, 07 Aug 2020 13:07:19 -04:00
Committer: Paul E. McKenney <paulmck@kernel.org>
CommitterDate: Mon, 24 Aug 2020 18:37:55 -07:00
rcu: Clarify comments about FQS loop reporting quiescent states
Since at least v4.19, the FQS loop no longer reports quiescent states
for offline CPUs except in emergency situations.
This commit therefore fixes the comment in rcu_gp_init() to match the
current code.
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/tree.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 52108dd..2c7afe4 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1706,10 +1706,13 @@ static bool rcu_gp_init(void)
raw_spin_unlock_irq_rcu_node(rnp);
/*
- * Apply per-leaf buffered online and offline operations to the
- * rcu_node tree. Note that this new grace period need not wait
- * for subsequent online CPUs, and that quiescent-state forcing
- * will handle subsequent offline CPUs.
+ * Apply per-leaf buffered online and offline operations to
+ * the rcu_node tree. Note that this new grace period need not
+ * wait for subsequent online CPUs, and that RCU hooks in the CPU
+ * offlining path, when combined with checks in this function,
+ * will handle CPUs that are currently going offline or that will
+ * go offline later. Please also refer to "Hotplug CPU" section
+ * of RCU's Requirements documentation.
*/
rcu_state.gp_state = RCU_GP_ONOFF;
rcu_for_each_leaf_node(rnp) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-09 6:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 6:35 [tip: core/rcu] rcu: Clarify comments about FQS loop reporting quiescent states tip-bot2 for Joel Fernandes (Google)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®