* [PATCH] perf: correct SNOOPX field offset
@ 2020-09-21 20:46 Al Grant
2020-10-19 17:02 ` [tip: perf/urgent] " tip-bot2 for Al Grant
2020-10-19 17:44 ` tip-bot2 for Al Grant
0 siblings, 2 replies; 3+ messages in thread
From: Al Grant @ 2020-09-21 20:46 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Jiri Olsa, Namhyung Kim, linux-perf-users,
linux-kernel, Alexander Shishkin
perf_event.h has macros that define the field offsets in the
data_src bitmask in perf records. The SNOOPX and REMOTE offsets
were both 37. These are distinct fields, and the bitfield layout
in perf_mem_data_src confirms that SNOOPX should be at offset 38.
Fixes: 52839e653b5629bd ("perf tools: Add support for printing new
mem_info encodings")
Signed-off-by: Al Grant <al.grant@foss.arm.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
---
include/uapi/linux/perf_event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/perf_event.h
b/include/uapi/linux/perf_event.h
index 077e7ee69e3d..3e5dcdd48a49 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -1196,7 +1196,7 @@ union perf_mem_data_src {
#define PERF_MEM_SNOOPX_FWD 0x01 /* forward */
/* 1 free */
-#define PERF_MEM_SNOOPX_SHIFT 37
+#define PERF_MEM_SNOOPX_SHIFT 38
/* locked instruction */
#define PERF_MEM_LOCK_NA 0x01 /* not available */
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: perf/urgent] perf: correct SNOOPX field offset
2020-09-21 20:46 [PATCH] perf: correct SNOOPX field offset Al Grant
@ 2020-10-19 17:02 ` tip-bot2 for Al Grant
2020-10-19 17:44 ` tip-bot2 for Al Grant
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Al Grant @ 2020-10-19 17:02 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Al Grant, Peter Zijlstra (Intel), Andi Kleen, x86, LKML
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 04de3266214453deb5f1d7849a66313e351af8cc
Gitweb: https://git.kernel.org/tip/04de3266214453deb5f1d7849a66313e351af8cc
Author: Al Grant <al.grant@foss.arm.com>
AuthorDate: Mon, 21 Sep 2020 21:46:37 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 19 Oct 2020 18:51:19 +02:00
perf: correct SNOOPX field offset
perf_event.h has macros that define the field offsets in the
data_src bitmask in perf records. The SNOOPX and REMOTE offsets
were both 37. These are distinct fields, and the bitfield layout
in perf_mem_data_src confirms that SNOOPX should be at offset 38.
Fixes: 52839e653b5629bd ("perf tools: Add support for printing new mem_info encodings")
Signed-off-by: Al Grant <al.grant@foss.arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Link: https://lkml.kernel.org/r/4ac9f5cc-4388-b34a-9999-418a4099415d@foss.arm.com
---
include/uapi/linux/perf_event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 077e7ee..b95d3c4 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -1196,7 +1196,7 @@ union perf_mem_data_src {
#define PERF_MEM_SNOOPX_FWD 0x01 /* forward */
/* 1 free */
-#define PERF_MEM_SNOOPX_SHIFT 37
+#define PERF_MEM_SNOOPX_SHIFT 38
/* locked instruction */
#define PERF_MEM_LOCK_NA 0x01 /* not available */
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: perf/urgent] perf: correct SNOOPX field offset
2020-09-21 20:46 [PATCH] perf: correct SNOOPX field offset Al Grant
2020-10-19 17:02 ` [tip: perf/urgent] " tip-bot2 for Al Grant
@ 2020-10-19 17:44 ` tip-bot2 for Al Grant
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Al Grant @ 2020-10-19 17:44 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Al Grant, Peter Zijlstra (Intel), Andi Kleen, x86, LKML
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: f3d301c1f2f5676465cdf3259737ea19cc82731f
Gitweb: https://git.kernel.org/tip/f3d301c1f2f5676465cdf3259737ea19cc82731f
Author: Al Grant <al.grant@foss.arm.com>
AuthorDate: Mon, 21 Sep 2020 21:46:37 +01:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 19 Oct 2020 19:39:22 +02:00
perf: correct SNOOPX field offset
perf_event.h has macros that define the field offsets in the
data_src bitmask in perf records. The SNOOPX and REMOTE offsets
were both 37. These are distinct fields, and the bitfield layout
in perf_mem_data_src confirms that SNOOPX should be at offset 38.
Fixes: 52839e653b5629bd ("perf tools: Add support for printing new mem_info encodings")
Signed-off-by: Al Grant <al.grant@foss.arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Link: https://lkml.kernel.org/r/4ac9f5cc-4388-b34a-9999-418a4099415d@foss.arm.com
---
include/uapi/linux/perf_event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 077e7ee..b95d3c4 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -1196,7 +1196,7 @@ union perf_mem_data_src {
#define PERF_MEM_SNOOPX_FWD 0x01 /* forward */
/* 1 free */
-#define PERF_MEM_SNOOPX_SHIFT 37
+#define PERF_MEM_SNOOPX_SHIFT 38
/* locked instruction */
#define PERF_MEM_LOCK_NA 0x01 /* not available */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-19 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 20:46 [PATCH] perf: correct SNOOPX field offset Al Grant
2020-10-19 17:02 ` [tip: perf/urgent] " tip-bot2 for Al Grant
2020-10-19 17:44 ` tip-bot2 for Al Grant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®