* [PATCH] ASoc: qcom: lpass-cpu: fix warning on symbol scope
@ 2020-11-05 11:41 Srinivas Kandagatla
2020-11-05 16:45 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Kandagatla @ 2020-11-05 11:41 UTC (permalink / raw)
To: broonie; +Cc: perex, alsa-devel, linux-kernel, lgirdwood, Srinivas Kandagatla
This patch fixes below warning when module is compiled with W=1 C=1
lpass-cpu.c:677:22: warning: symbol 'lpass_hdmi_regmap_config'
was not declared. Should it be static?
Fixes: 7cb37b7bd0d3 ("ASoC: qcom: Add support for lpass hdmi driver")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/qcom/lpass-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index 9d17c87445a9..1fd862e3fd8a 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b/sound/soc/qcom/lpass-cpu.c
@@ -674,7 +674,7 @@ static bool lpass_hdmi_regmap_volatile(struct device *dev, unsigned int reg)
return false;
}
-struct regmap_config lpass_hdmi_regmap_config = {
+static struct regmap_config lpass_hdmi_regmap_config = {
.reg_bits = 32,
.reg_stride = 4,
.val_bits = 32,
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoc: qcom: lpass-cpu: fix warning on symbol scope
2020-11-05 11:41 [PATCH] ASoc: qcom: lpass-cpu: fix warning on symbol scope Srinivas Kandagatla
@ 2020-11-05 16:45 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-11-05 16:45 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: alsa-devel, linux-kernel, lgirdwood
On Thu, 5 Nov 2020 11:41:00 +0000, Srinivas Kandagatla wrote:
> This patch fixes below warning when module is compiled with W=1 C=1
>
> lpass-cpu.c:677:22: warning: symbol 'lpass_hdmi_regmap_config'
> was not declared. Should it be static?
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: lpass-cpu: fix warning on symbol scope
commit: 20f64a1db8a06fdf4ed03375546f8d3555cb6cc9
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-05 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 11:41 [PATCH] ASoc: qcom: lpass-cpu: fix warning on symbol scope Srinivas Kandagatla
2020-11-05 16:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®