* [V2] trace: Fix passing zero to PTR_ERR()
@ 2020-11-07 6:34 Wang Qing
2020-11-07 7:36 ` Yonghong Song
0 siblings, 1 reply; 2+ messages in thread
From: Wang Qing @ 2020-11-07 6:34 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar, Alexei Starovoitov, Daniel Borkmann,
Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko,
John Fastabend, KP Singh, netdev, bpf, linux-kernel
Cc: Wang Qing
There is a bug when passing zero to PTR_ERR() and return.
Fix smatch err.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
kernel/trace/bpf_trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 4517c8b..5113fd4
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -1198,7 +1198,7 @@ static int bpf_btf_printf_prepare(struct btf_ptr *ptr, u32 btf_ptr_size,
*btf = bpf_get_btf_vmlinux();
if (IS_ERR_OR_NULL(*btf))
- return PTR_ERR(*btf);
+ return IS_ERR(*btf) ? PTR_ERR(*btf) : -EINVAL;
if (ptr->type_id > 0)
*btf_id = ptr->type_id;
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [V2] trace: Fix passing zero to PTR_ERR()
2020-11-07 6:34 [V2] trace: Fix passing zero to PTR_ERR() Wang Qing
@ 2020-11-07 7:36 ` Yonghong Song
0 siblings, 0 replies; 2+ messages in thread
From: Yonghong Song @ 2020-11-07 7:36 UTC (permalink / raw)
To: Wang Qing, Steven Rostedt, Ingo Molnar, Alexei Starovoitov,
Daniel Borkmann, Martin KaFai Lau, Song Liu, Andrii Nakryiko,
John Fastabend, KP Singh, netdev, bpf, linux-kernel
On 11/6/20 10:34 PM, Wang Qing wrote:
> There is a bug when passing zero to PTR_ERR() and return.
> Fix smatch err.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
For clarity, the subject probably should be
bpf: Fix passing zero to PTR_ERR()
to indicate this is a bpf related fix. The tag should
be something like
[PATCH bpf v2] or [PATCH v2 bpf]
depending on your preference, to indicate this is for bpf tree.
If another version is sent, the above "v2" should change to "v3".
> ---
> kernel/trace/bpf_trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index 4517c8b..5113fd4
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -1198,7 +1198,7 @@ static int bpf_btf_printf_prepare(struct btf_ptr *ptr, u32 btf_ptr_size,
> *btf = bpf_get_btf_vmlinux();
>
> if (IS_ERR_OR_NULL(*btf))
> - return PTR_ERR(*btf);
> + return IS_ERR(*btf) ? PTR_ERR(*btf) : -EINVAL;
>
> if (ptr->type_id > 0)
> *btf_id = ptr->type_id;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-07 7:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-07 6:34 [V2] trace: Fix passing zero to PTR_ERR() Wang Qing
2020-11-07 7:36 ` Yonghong Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®