* [PATCH] scsi: pmcraid: replace atomic_add_return()
@ 2020-11-16 7:50 Yejune Deng
0 siblings, 0 replies; only message in thread
From: Yejune Deng @ 2020-11-16 7:50 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, yejune.deng
atomic_inc_return() looks better
Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
drivers/scsi/pmcraid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index cbe5fab..3e5b70c 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3381,7 +3381,7 @@ static int pmcraid_queuecommand_lck(
* block of scsi_cmd which is re-used (e.g. cancel/abort), which uses
* hrrq_id assigned here in queuecommand
*/
- ioarcb->hrrq_id = atomic_add_return(1, &(pinstance->last_message_id)) %
+ ioarcb->hrrq_id = atomic_inc_return(&pinstance->last_message_id) %
pinstance->num_hrrq;
cmd->cmd_done = pmcraid_io_done;
@@ -3684,7 +3684,7 @@ static long pmcraid_ioctl_passthrough(
* block of scsi_cmd which is re-used (e.g. cancel/abort), which uses
* hrrq_id assigned here in queuecommand
*/
- ioarcb->hrrq_id = atomic_add_return(1, &(pinstance->last_message_id)) %
+ ioarcb->hrrq_id = atomic_inc_return(&pinstance->last_message_id) %
pinstance->num_hrrq;
if (request_size) {
--
1.9.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-16 7:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 7:50 [PATCH] scsi: pmcraid: replace atomic_add_return() Yejune Deng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome