* [PATCH net] net: ethernet: ti: cpsw: fix error return code in cpsw_probe()
@ 2020-11-13 6:49 Zhang Changzhong
2020-11-16 23:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2020-11-13 6:49 UTC (permalink / raw)
To: grygorii.strashko, davem, kuba, m-karicheri2, brouer,
richardcochran, yanaijie
Cc: linux-omap, netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/ethernet/ti/cpsw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 9fd1f77..7882a00 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -1631,6 +1631,7 @@ static int cpsw_probe(struct platform_device *pdev)
CPSW_MAX_QUEUES, CPSW_MAX_QUEUES);
if (!ndev) {
dev_err(dev, "error allocating net_device\n");
+ ret = -ENOMEM;
goto clean_cpts;
}
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net] net: ethernet: ti: cpsw: fix error return code in cpsw_probe()
2020-11-13 6:49 [PATCH net] net: ethernet: ti: cpsw: fix error return code in cpsw_probe() Zhang Changzhong
@ 2020-11-16 23:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-11-16 23:50 UTC (permalink / raw)
To: Zhang Changzhong
Cc: grygorii.strashko, davem, kuba, m-karicheri2, brouer,
richardcochran, yanaijie, linux-omap, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 13 Nov 2020 14:49:33 +0800 you wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group common hw initialization")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
>
> [...]
Here is the summary with links:
- [net] net: ethernet: ti: cpsw: fix error return code in cpsw_probe()
https://git.kernel.org/netdev/net/c/35f735c66511
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 23:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 6:49 [PATCH net] net: ethernet: ti: cpsw: fix error return code in cpsw_probe() Zhang Changzhong
2020-11-16 23:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®