* [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors
@ 2020-11-24 9:47 Tiezhu Yang
2020-11-25 2:24 ` Chunfeng Yun
0 siblings, 1 reply; 5+ messages in thread
From: Tiezhu Yang @ 2020-11-24 9:47 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Chunfeng Yun
Cc: linux-arm-kernel, linux-mediatek, linux-kernel, Heiko Stuebner,
Xuefeng Li
devm_ioremap_resource() will be not built in lib/devres.c if
CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
set, and then there exists two build errors about undefined
reference to "devm_ioremap_resource" and "of_address_to_resource"
in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/phy/mediatek/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
index 50c5e93..66df045 100644
--- a/drivers/phy/mediatek/Kconfig
+++ b/drivers/phy/mediatek/Kconfig
@@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
tristate "MediaTek XS-PHY Driver"
depends on ARCH_MEDIATEK || COMPILE_TEST
depends on OF
+ depends on HAS_IOMEM
+ depends on OF_ADDRESS
select GENERIC_PHY
help
Enable this to support the SuperSpeedPlus XS-PHY transceiver for
--
2.1.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors
2020-11-24 9:47 [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors Tiezhu Yang
@ 2020-11-25 2:24 ` Chunfeng Yun
2020-11-25 3:31 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Chunfeng Yun @ 2020-11-25 2:24 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Vinod Koul, Kishon Vijay Abraham I, linux-arm-kernel,
linux-mediatek, linux-kernel, Heiko Stuebner, Xuefeng Li
Hi Tiezhu,
On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote:
> devm_ioremap_resource() will be not built in lib/devres.c if
> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
> set, and then there exists two build errors about undefined
> reference to "devm_ioremap_resource" and "of_address_to_resource"
> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> drivers/phy/mediatek/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 50c5e93..66df045 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
> tristate "MediaTek XS-PHY Driver"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> depends on OF
> + depends on HAS_IOMEM
> + depends on OF_ADDRESS
Why not add them into deconfig but here? In fact I don't know which way
is better and follow the kernel rule.
Vinod and Kishon, do you have any suggestion about this?
> select GENERIC_PHY
> help
> Enable this to support the SuperSpeedPlus XS-PHY transceiver for
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors
2020-11-25 2:24 ` Chunfeng Yun
@ 2020-11-25 3:31 ` Randy Dunlap
2020-11-25 6:27 ` Chunfeng Yun
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2020-11-25 3:31 UTC (permalink / raw)
To: Chunfeng Yun, Tiezhu Yang
Cc: Vinod Koul, Kishon Vijay Abraham I, linux-arm-kernel,
linux-mediatek, linux-kernel, Heiko Stuebner, Xuefeng Li
On 11/24/20 6:24 PM, Chunfeng Yun wrote:
> Hi Tiezhu,
>
> On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote:
>> devm_ioremap_resource() will be not built in lib/devres.c if
>> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
>> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
>> set, and then there exists two build errors about undefined
>> reference to "devm_ioremap_resource" and "of_address_to_resource"
>> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
>> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> drivers/phy/mediatek/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
>> index 50c5e93..66df045 100644
>> --- a/drivers/phy/mediatek/Kconfig
>> +++ b/drivers/phy/mediatek/Kconfig
>> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
>> tristate "MediaTek XS-PHY Driver"
>> depends on ARCH_MEDIATEK || COMPILE_TEST
>> depends on OF
>> + depends on HAS_IOMEM
>> + depends on OF_ADDRESS
> Why not add them into deconfig but here? In fact I don't know which way
> is better and follow the kernel rule.
>
> Vinod and Kishon, do you have any suggestion about this?
Putting them into a defconfig won't prevent random build errors
while putting them here will (or at least should).
>> select GENERIC_PHY
>> help
>> Enable this to support the SuperSpeedPlus XS-PHY transceiver for
>
The patch LGTM.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors
2020-11-25 3:31 ` Randy Dunlap
@ 2020-11-25 6:27 ` Chunfeng Yun
2020-11-25 6:31 ` Tiezhu Yang
0 siblings, 1 reply; 5+ messages in thread
From: Chunfeng Yun @ 2020-11-25 6:27 UTC (permalink / raw)
To: Randy Dunlap, Tiezhu Yang
Cc: Tiezhu Yang, Vinod Koul, Kishon Vijay Abraham I,
linux-arm-kernel, linux-mediatek, linux-kernel, Heiko Stuebner,
Xuefeng Li
On Tue, 2020-11-24 at 19:31 -0800, Randy Dunlap wrote:
> On 11/24/20 6:24 PM, Chunfeng Yun wrote:
> > Hi Tiezhu,
> >
> > On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote:
> >> devm_ioremap_resource() will be not built in lib/devres.c if
> >> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
> >> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
> >> set, and then there exists two build errors about undefined
> >> reference to "devm_ioremap_resource" and "of_address_to_resource"
> >> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
> >> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
> >>
> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> >> ---
> >> drivers/phy/mediatek/Kconfig | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> >> index 50c5e93..66df045 100644
> >> --- a/drivers/phy/mediatek/Kconfig
> >> +++ b/drivers/phy/mediatek/Kconfig
> >> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
> >> tristate "MediaTek XS-PHY Driver"
> >> depends on ARCH_MEDIATEK || COMPILE_TEST
> >> depends on OF
Hi Tiezhu,
Would you please help to put OF and OF_ADDRESS into one line as
following:
depends on OF && OF_ADDRESS.
Also please help to add them for PHY_MTK_TPHY.
And change the tile 'phy/mediatek: ...' as 'phy: mediatek: ...'
Thank you
> >> + depends on HAS_IOMEM
> >> + depends on OF_ADDRESS
> > Why not add them into deconfig but here? In fact I don't know which way
> > is better and follow the kernel rule.
> >
> > Vinod and Kishon, do you have any suggestion about this?
>
> Putting them into a defconfig won't prevent random build errors
> while putting them here will (or at least should).
hi Randy,
Got it, thank you
>
> >> select GENERIC_PHY
> >> help
> >> Enable this to support the SuperSpeedPlus XS-PHY transceiver for
> >
>
> The patch LGTM.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors
2020-11-25 6:27 ` Chunfeng Yun
@ 2020-11-25 6:31 ` Tiezhu Yang
0 siblings, 0 replies; 5+ messages in thread
From: Tiezhu Yang @ 2020-11-25 6:31 UTC (permalink / raw)
To: Chunfeng Yun, Randy Dunlap
Cc: Vinod Koul, Kishon Vijay Abraham I, linux-arm-kernel,
linux-mediatek, linux-kernel, Heiko Stuebner, Xuefeng Li
On 11/25/2020 02:27 PM, Chunfeng Yun wrote:
> On Tue, 2020-11-24 at 19:31 -0800, Randy Dunlap wrote:
>> On 11/24/20 6:24 PM, Chunfeng Yun wrote:
>>> Hi Tiezhu,
>>>
>>> On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote:
>>>> devm_ioremap_resource() will be not built in lib/devres.c if
>>>> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
>>>> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
>>>> set, and then there exists two build errors about undefined
>>>> reference to "devm_ioremap_resource" and "of_address_to_resource"
>>>> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
>>>> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>>> ---
>>>> drivers/phy/mediatek/Kconfig | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
>>>> index 50c5e93..66df045 100644
>>>> --- a/drivers/phy/mediatek/Kconfig
>>>> +++ b/drivers/phy/mediatek/Kconfig
>>>> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
>>>> tristate "MediaTek XS-PHY Driver"
>>>> depends on ARCH_MEDIATEK || COMPILE_TEST
>>>> depends on OF
> Hi Tiezhu,
>
> Would you please help to put OF and OF_ADDRESS into one line as
> following:
> depends on OF && OF_ADDRESS.
>
> Also please help to add them for PHY_MTK_TPHY.
> And change the tile 'phy/mediatek: ...' as 'phy: mediatek: ...'
OK, no problem, I will do it.
Thanks,
Tiezhu
>
> Thank you
>
>
>>>> + depends on HAS_IOMEM
>>>> + depends on OF_ADDRESS
>>> Why not add them into deconfig but here? In fact I don't know which way
>>> is better and follow the kernel rule.
>>>
>>> Vinod and Kishon, do you have any suggestion about this?
>> Putting them into a defconfig won't prevent random build errors
>> while putting them here will (or at least should).
> hi Randy,
>
> Got it, thank you
>
>>>> select GENERIC_PHY
>>>> help
>>>> Enable this to support the SuperSpeedPlus XS-PHY transceiver for
>> The patch LGTM.
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-25 6:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 9:47 [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors Tiezhu Yang
2020-11-25 2:24 ` Chunfeng Yun
2020-11-25 3:31 ` Randy Dunlap
2020-11-25 6:27 ` Chunfeng Yun
2020-11-25 6:31 ` Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®