mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: mikpe@csd.uu.se
To: Pavel Machek <pavel@suse.cz>
Cc: Adrian Bunk <bunk@fs.tum.de>, Andrew Morton <akpm@digeo.com>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.5.69-mm5: CONFIG_ACPI_SLEEP compile error
Date: Thu, 15 May 2003 11:46:40 +0200	[thread overview]
Message-ID: <16067.25088.905125.474440@gargle.gargle.HOWL> (raw)
In-Reply-To: <20030514225157.GA13427@elf.ucw.cz>

Pavel Machek writes:
 > Hi!
 > 
 > Mikpe, is this your diff? 
 > 
 > revision 1.16
 > date: 2003/05/11 18:58:48;  author: mikpe;  state: Exp;  lines: +2 -4
 > restore sysenter MSRs at APM resume
 > 
 > I do not know why you changed it (it has certainly nothing to do with
 > APM resume)... Please revert it.

I've just posted a fix for the compile error.

APM suspend and resume now use the save and restore processor state
procedures in suspend.c. The only alternative is to duplicate that
functionality in apm.c or a new "suspend-but-not-tied-to-acpi.c" file.
But suspend.c is fairly generic so it makes sense to share it with APM.

The suspend.c changes are cleanups. The variables are only used in acpi's
suspend_asm.S and acpi/wakeup.S, so I moved them to suspend_asm.S since
they aren't needed when suspend is done by APM. fix_processor_context()
isn't used outside of suspend.c so I made it static.

Do you still have a problem with this?

/Mikael

  reply	other threads:[~2003-05-15  9:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-14  8:29 2.5.69-mm5 Andrew Morton
2003-05-14 12:33 ` 2.5.69-mm5 Ed Tomlinson
2003-05-14 14:47 ` 2.5.69-mm5: sb1000.c: undefined reference to `alloc_netdev' Adrian Bunk
2003-05-14 17:31   ` Andrew Morton
2003-05-14 18:26     ` Alan Cox
2003-05-14 19:41       ` Andrew Morton
2003-05-15  1:49         ` David S. Miller
2003-05-14 21:45 ` 2.5.69-mm5: CONFIG_ACPI_SLEEP compile error Adrian Bunk
2003-05-14 22:51   ` Pavel Machek
2003-05-15  9:46     ` mikpe [this message]
2003-05-15 14:52       ` Pavel Machek
2003-05-15  9:29   ` mikpe
2003-05-15  8:59 ` 2.5.69-mm5 Helge Hafting
2003-05-15 19:51 ` 2.5.69-mm5 William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16067.25088.905125.474440@gargle.gargle.HOWL \
    --to=mikpe@csd.uu.se \
    --cc=akpm@digeo.com \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®