From: Pavel Machek <pavel@suse.cz>
To: Adrian Bunk <bunk@fs.tum.de>, mikpe@csd.uu.ee
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.69-mm5: CONFIG_ACPI_SLEEP compile error
Date: Thu, 15 May 2003 00:51:57 +0200 [thread overview]
Message-ID: <20030514225157.GA13427@elf.ucw.cz> (raw)
In-Reply-To: <20030514214536.GK1346@fs.tum.de>
Hi!
Mikpe, is this your diff?
revision 1.16
date: 2003/05/11 18:58:48; author: mikpe; state: Exp; lines: +2 -4
restore sysenter MSRs at APM resume
I do not know why you changed it (it has certainly nothing to do with
APM resume)... Please revert it.
Pavel
Index: suspend.c
===================================================================
RCS file:
/home/pavel/sf/bitbucket/bkcvs/linux-2.5/arch/i386/kernel/suspend.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- suspend.c 8 Apr 2003 16:46:44 -0000 1.15
+++ suspend.c 11 May 2003 18:58:48 -0000 1.16
@@ -27,9 +27,7 @@
#include <asm/tlbflush.h>
static struct saved_context saved_context;
-unsigned long saved_context_eax, saved_context_ebx,
saved_context_ecx, saved_context_edx;
-unsigned long saved_context_esp, saved_context_ebp,
saved_context_esi, saved_context_edi;
-unsigned long saved_context_eflags;
+static void fix_processor_context(void);
extern void enable_sep_cpu(void *);
@@ -107,7 +105,7 @@
do_fpu_end();
}
-void fix_processor_context(void)
+static void fix_processor_context(void)
{
int cpu = smp_processor_id();
struct tss_struct * t = init_tss + cpu;
> It seems the following problem comes from Linus' tree:
>
> <-- snip -->
>
> ...
> ... --end-group -o .tmp_vmlinux1
> arch/i386/kernel/built-in.o(.data+0x1fae): In function `do_suspend_lowlevel':
> : undefined reference to `saved_context_esp'
> arch/i386/kernel/built-in.o(.data+0x1fb3): In function `do_suspend_lowlevel':
> : undefined reference to `saved_context_eax'
> arch/i386/kernel/built-in.o(.data+0x1fb9): In function `do_suspend_lowlevel':
> : undefined reference to `saved_context_ebx'
> ...
> make: *** [.tmp_vmlinux1] Error 1
>
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-05-14 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 8:29 2.5.69-mm5 Andrew Morton
2003-05-14 12:33 ` 2.5.69-mm5 Ed Tomlinson
2003-05-14 14:47 ` 2.5.69-mm5: sb1000.c: undefined reference to `alloc_netdev' Adrian Bunk
2003-05-14 17:31 ` Andrew Morton
2003-05-14 18:26 ` Alan Cox
2003-05-14 19:41 ` Andrew Morton
2003-05-15 1:49 ` David S. Miller
2003-05-14 21:45 ` 2.5.69-mm5: CONFIG_ACPI_SLEEP compile error Adrian Bunk
2003-05-14 22:51 ` Pavel Machek [this message]
2003-05-15 9:46 ` mikpe
2003-05-15 14:52 ` Pavel Machek
2003-05-15 9:29 ` mikpe
2003-05-15 8:59 ` 2.5.69-mm5 Helge Hafting
2003-05-15 19:51 ` 2.5.69-mm5 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030514225157.GA13427@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@digeo.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®