From: vjitta@codeaurora.org
To: minchan@kernel.org, vincenzo.frascino@arm.com, glider@google.com,
dan.j.williams@intel.com, broonie@kernel.org,
mhiramat@kernel.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
andreyknvl@google.com, qcai@redhat.com, vjitta@codeaurora.org,
ylal@codeaurora.org, vinmenon@codeaurora.org
Subject: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE
Date: Thu, 10 Dec 2020 10:30:01 +0530 [thread overview]
Message-ID: <1607576401-25609-1-git-send-email-vjitta@codeaurora.org> (raw)
From: Yogesh Lal <ylal@codeaurora.org>
Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE.
Aim is to have configurable value for STACK_HASH_SIZE, so that one
can configure it depending on usecase there by reducing the static
memory overhead.
One example is of Page Owner, default value of STACK_HASH_SIZE lead
stack depot to consume 8MB of static memory. Making it configurable
and use lower value helps to enable features like CONFIG_PAGE_OWNER
without any significant overhead.
Suggested-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Yogesh Lal <ylal@codeaurora.org>
Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
---
lib/stackdepot.c | 31 +++++++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 81c69c0..e0eebfd 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -30,6 +30,7 @@
#include <linux/stackdepot.h>
#include <linux/string.h>
#include <linux/types.h>
+#include <linux/vmalloc.h>
#define DEPOT_STACK_BITS (sizeof(depot_stack_handle_t) * 8)
@@ -141,14 +142,36 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
return stack;
}
-#define STACK_HASH_ORDER 20
-#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER)
+#define MAX_STACK_HASH_ORDER 20
+#define MAX_STACK_HASH_SIZE (1L << MAX_STACK_HASH_ORDER)
+#define STACK_HASH_SIZE (1L << stack_hash_order)
#define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
#define STACK_HASH_SEED 0x9747b28c
-static struct stack_record *stack_table[STACK_HASH_SIZE] = {
- [0 ... STACK_HASH_SIZE - 1] = NULL
+static unsigned int stack_hash_order = 20;
+static struct stack_record *stack_table_def[MAX_STACK_HASH_SIZE] __initdata = {
+ [0 ... MAX_STACK_HASH_SIZE - 1] = NULL
};
+static struct stack_record **stack_table __refdata = stack_table_def;
+
+static int __init setup_stack_hash_order(char *str)
+{
+ kstrtouint(str, 0, &stack_hash_order);
+ if (stack_hash_order > MAX_STACK_HASH_ORDER)
+ stack_hash_order = MAX_STACK_HASH_ORDER;
+ return 0;
+}
+early_param("stack_hash_order", setup_stack_hash_order);
+
+static int __init init_stackdepot(void)
+{
+ size_t size = (STACK_HASH_SIZE * sizeof(struct stack_record *));
+
+ stack_table = vmalloc(size);
+ memcpy(stack_table, stack_table_def, size);
+ return 0;
+}
+early_initcall(init_stackdepot);
/* Calculate hash for a stack */
static inline u32 hash_stack(unsigned long *entries, unsigned int size)
--
2.7.4
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next reply other threads:[~2020-12-10 5:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 5:00 vjitta [this message]
2020-12-11 8:36 ` Alexander Potapenko
2020-12-11 12:45 ` Vijayanand Jitta
2020-12-11 13:25 ` Alexander Potapenko
2020-12-14 4:02 ` Vijayanand Jitta
2020-12-14 9:34 ` Alexander Potapenko
2020-12-14 10:32 ` Vijayanand Jitta
2020-12-16 3:43 ` Vijayanand Jitta
2020-12-16 8:26 ` Alexander Potapenko
2020-12-16 13:06 ` Vijayanand Jitta
2020-12-16 13:11 ` Alexander Potapenko
2020-12-16 13:22 ` Vijayanand Jitta
2020-12-16 13:34 ` Alexander Potapenko
2020-12-17 5:38 ` Vijayanand Jitta
2020-12-17 10:19 ` Dmitry Vyukov
2020-12-17 10:54 ` Alexander Potapenko
2020-12-18 8:40 ` Vijayanand Jitta
2020-12-21 11:14 ` Vijayanand Jitta
2020-12-21 15:04 ` Alexander Potapenko
2020-12-21 20:29 ` Minchan Kim
2020-12-22 5:55 ` Vijayanand Jitta
2020-12-23 14:40 ` Alexander Potapenko
2020-12-28 4:51 ` Vijayanand Jitta
2020-12-15 9:34 ` [lib] 1333d0ba67: WARNING:at_kernel/locking/lockdep.c:#lockdep_register_key kernel test robot
2020-12-17 10:25 ` [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE Dmitry Vyukov
2020-12-17 10:27 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1607576401-25609-1-git-send-email-vjitta@codeaurora.org \
--to=vjitta@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minchan@kernel.org \
--cc=qcai@redhat.com \
--cc=vincenzo.frascino@arm.com \
--cc=vinmenon@codeaurora.org \
--cc=ylal@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome