From: Vijayanand Jitta <vjitta@codeaurora.org>
To: Alexander Potapenko <glider@google.com>
Cc: Minchan Kim <minchan@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
dan.j.williams@intel.com, broonie@kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@google.com>,
qcai@redhat.com, ylal@codeaurora.org, vinmenon@codeaurora.org,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE
Date: Mon, 28 Dec 2020 10:21:31 +0530 [thread overview]
Message-ID: <dbce90d4-17e5-15a3-4336-9efede16c772@codeaurora.org> (raw)
In-Reply-To: <CAG_fn=UUo3tP1XtdOntNG1krvbPV7pmE9XXwMyuhL2gMUoc4Jw@mail.gmail.com>
On 12/23/2020 8:10 PM, Alexander Potapenko wrote:
>>
>> Michan, We would still need config option so that we can reduce the
>> memory consumption on low ram devices using config.
>>
>> Alex, On this,
>> "I also suppose device vendors may prefer setting a fixed (maybe
>> non-default) hash size for low-memory devices rather than letting the
>> admins increase it."
>> I see kernel param swiotlb does similar thing i.e; '0' to disable and
>> set a value to configure size.
>>
>> I am fine with either of the approaches,
>>
>> 1. I can split this patch into two
>> i) A bool variable to enable/disable stack depot.
>> ii) A config for the size.
>
> I still believe this is a more appropriate solution.
>
> Thanks in advance!
>
Thanks, Will work on a patch with above approach.
Thanks,
Vijay
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-12-28 4:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 5:00 vjitta
2020-12-11 8:36 ` Alexander Potapenko
2020-12-11 12:45 ` Vijayanand Jitta
2020-12-11 13:25 ` Alexander Potapenko
2020-12-14 4:02 ` Vijayanand Jitta
2020-12-14 9:34 ` Alexander Potapenko
2020-12-14 10:32 ` Vijayanand Jitta
2020-12-16 3:43 ` Vijayanand Jitta
2020-12-16 8:26 ` Alexander Potapenko
2020-12-16 13:06 ` Vijayanand Jitta
2020-12-16 13:11 ` Alexander Potapenko
2020-12-16 13:22 ` Vijayanand Jitta
2020-12-16 13:34 ` Alexander Potapenko
2020-12-17 5:38 ` Vijayanand Jitta
2020-12-17 10:19 ` Dmitry Vyukov
2020-12-17 10:54 ` Alexander Potapenko
2020-12-18 8:40 ` Vijayanand Jitta
2020-12-21 11:14 ` Vijayanand Jitta
2020-12-21 15:04 ` Alexander Potapenko
2020-12-21 20:29 ` Minchan Kim
2020-12-22 5:55 ` Vijayanand Jitta
2020-12-23 14:40 ` Alexander Potapenko
2020-12-28 4:51 ` Vijayanand Jitta [this message]
2020-12-15 9:34 ` [lib] 1333d0ba67: WARNING:at_kernel/locking/lockdep.c:#lockdep_register_key kernel test robot
2020-12-17 10:25 ` [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE Dmitry Vyukov
2020-12-17 10:27 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbce90d4-17e5-15a3-4336-9efede16c772@codeaurora.org \
--to=vjitta@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minchan@kernel.org \
--cc=qcai@redhat.com \
--cc=vincenzo.frascino@arm.com \
--cc=vinmenon@codeaurora.org \
--cc=ylal@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome