* [PATCH] irqchip/gic: remove a if in gic_of_setup()
@ 2020-12-30 2:30 Yejune Deng
0 siblings, 0 replies; only message in thread
From: Yejune Deng @ 2020-12-30 2:30 UTC (permalink / raw)
To: tglx, maz; +Cc: linux-kernel, yejune.deng
There is two function gic_of_init() and gic_of_init_child() called
gic_of_setup(),both gic and node never fail,so remove
if (!gic || !node) is safe.
Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
drivers/irqchip/irq-gic.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index b1d9c22..a65678f0 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1380,9 +1380,6 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
{
- if (!gic || !node)
- return -EINVAL;
-
gic->raw_dist_base = of_iomap(node, 0);
if (WARN(!gic->raw_dist_base, "unable to map gic dist registers\n"))
goto error;
--
1.9.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-30 2:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 2:30 [PATCH] irqchip/gic: remove a if in gic_of_setup() Yejune Deng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®