mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: problem with blk_queue_bounce_limit()
Date: Wed, 4 Jun 2003 23:42:16 -0700	[thread overview]
Message-ID: <16094.58952.941468.221985@napali.hpl.hp.com> (raw)

On platforms with I/O MMU hardware, memory above 4GB, and IDE hard disks,
this check:

		BUG_ON(dma_addr < BLK_BOUNCE_ISA);

causes an instant panic.  The reason is quite obvious: since there is
an I/O MMU, BLK_BOUNCE_ISA is effectively unlimited, and most IDE
controllers can of course DMA only to <4GB.

So, the check is wrong.  I think the proper way to fix this is to pass
a "struct dev" into the routine and then to use dma_supported() to
check whether bounce buffers will be needed.  Do you agree?  If so,
can you fix it?

Thanks,

	--david

             reply	other threads:[~2003-06-05  6:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-05  6:42 David Mosberger [this message]
2003-06-05  7:20 ` David S. Miller
2003-06-06  6:42   ` David Mosberger
2003-06-06  6:45     ` David S. Miller
2003-06-06  6:54       ` David Mosberger
2003-06-06  7:08         ` David S. Miller
2003-06-06  6:52     ` David S. Miller
2003-06-06  7:19       ` David Mosberger
2003-06-06  7:32         ` David S. Miller
2003-06-06  7:44           ` Christoph Hellwig
2003-06-06  7:43             ` David S. Miller
2003-06-06  7:51               ` Christoph Hellwig
2003-06-06 20:13           ` David Mosberger
2003-06-07  6:44             ` David S. Miller
2003-06-07  7:05               ` David Mosberger
2003-06-07  7:11                 ` David S. Miller
2003-06-10 20:01                   ` David Mosberger
2003-06-12  6:47                     ` David S. Miller
2003-06-15  7:06                   ` Anton Blanchard
2003-06-15  7:11                     ` David S. Miller
2003-06-15  8:04                       ` Anton Blanchard
2003-06-15  8:18                         ` David S. Miller
2003-06-07  7:20               ` David Mosberger
2003-06-07  7:19                 ` David S. Miller
2003-06-07  9:44                 ` Russell King
2003-06-07  9:47                   ` David S. Miller
2003-06-07 13:23                     ` Christoph Hellwig
2003-06-10 20:24                 ` David Mosberger
2003-06-06 18:06 James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16094.58952.941468.221985@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=axboe@suse.de \
    --cc=davidm@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®