From: David Mosberger <davidm@napali.hpl.hp.com>
To: "David S. Miller" <davem@redhat.com>
Cc: davidm@hpl.hp.com, davidm@napali.hpl.hp.com,
manfred@colorfullife.com, axboe@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: problem with blk_queue_bounce_limit()
Date: Fri, 6 Jun 2003 13:13:38 -0700 [thread overview]
Message-ID: <200306062013.h56KDcLe026713@napali.hpl.hp.com> (raw)
In-Reply-To: <20030606.003230.15263591.davem@redhat.com>
>>>>> On Fri, 06 Jun 2003 00:32:30 -0700 (PDT), "David S. Miller" <davem@redhat.com> said:
David> From: David Mosberger <davidm@napali.hpl.hp.com> Date:
David> Fri, 6 Jun 2003 00:19:08 -0700
David> PCI_DMA_BUS_IS_PHYS (and it's description) is quite
David> misleading: it claims that it has something to do with there
David> being an equivalence between PCI bus and physical addresses.
David> That's actually the case for (small) ia64 platforms so that's
David> why we ended up setting it to 1.
David> It does have to do with such an equivalence. If your port
David> couldn't work if drivers use the deprecated
David> virt_to_bus/bus_to_virt, you must set PCI_DMA_BUS_IS_PHYS to
David> zero.
Yes, but the comment certainly is confusing. How about something like
this:
/*
* PCI_DMA_BUS_IS_PHYS should be set to 1 if there is necessarily a
* direct corespondence between device bus addresses and CPU physical
* addresses. Platforms with a hardware I/O MMU _must_ turn this off
* to suppress the bounce buffer handling code in the block and
* network device layers. Platforms with separate bus address spaces
* _must_ turn this off and provide a device DMA mapping
* implementation that takes care of the necessary address
* translation.
*/
#define PCI_DMA_BUS_IS_PHYS pci_dma_bus_is_phys
David> The whole block layer makes all kinds of assumptions about
David> what physically contiguous addresses mean about how they'll
David> be contiguous in the bus addresses the device will actually
David> use to perform the DMA transfer.
This sounds all very dramatic, but try as I might, all I find is three
places where PCI_DMA_BUS_IS_PHYS is used:
- ide-lib.c: used to disable bounce buffering
- scsi_lib.c: used to disable bounce buffering
- tg3.c: what the heck??
The tg3 code looks ugly in the extreme (sorry). If I understand it
right, it's trying to work around a bug which shows up when a packet
covers a certain address? With an I/O MMU, you then remap the
offending buffer again before freeing the old mapping which will
ensure a different address of the packet, whereas in the non-I/O MMU
case, you copy the entire socket buffer (since just remapping it won't
change the address and since there is no interface to copy just a
portion of a socket buffer) and then do the remapping.
Did I get this right (or at least close enough)?
It seems really bad to me to rely on implementation-specifics of the
DMA API. I suspect the code would break on a platform which has
separate bus address spaces but no (hardware) I/O TLB? (Yeah,
probably not a supported scenarious, but with a proper fix, this
wouldn't be a problem.)
Does this bug happen often enough that it's performance critical?
Otherwise, you could just always use the copy-the-entire-buffer
workaround. If its performance-critical, would it make sense
to extend the socket buffer API to allow copying a portion of
a buffer?
I really dislike PCI_DMA_BUS_IS_PHYS, because it introduces a
discontinuity. I don't think it should be necessary.
If it wasn't for tg3.c, couldn't PCI_DMA_BUS_IS_PHYS be gotten rid of
much more cleanly with a dma_max_phys_addr(dev) function, which would
return the maximum physical address that device DEV can address
(either directly, or via an I/O TLB)?
David> We could convert the few compile time checks of
David> PCI_DMA_BUS_IS_PHYS so that you can set this based upon the
David> configuration of the machine if for some configurations it is
David> true. drivers/net/tg3.c is the only offender, my bad :-)
Yes. Would you mind fixing that?
--david
next prev parent reply other threads:[~2003-06-06 20:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-05 6:42 David Mosberger
2003-06-05 7:20 ` David S. Miller
2003-06-06 6:42 ` David Mosberger
2003-06-06 6:45 ` David S. Miller
2003-06-06 6:54 ` David Mosberger
2003-06-06 7:08 ` David S. Miller
2003-06-06 6:52 ` David S. Miller
2003-06-06 7:19 ` David Mosberger
2003-06-06 7:32 ` David S. Miller
2003-06-06 7:44 ` Christoph Hellwig
2003-06-06 7:43 ` David S. Miller
2003-06-06 7:51 ` Christoph Hellwig
2003-06-06 20:13 ` David Mosberger [this message]
2003-06-07 6:44 ` David S. Miller
2003-06-07 7:05 ` David Mosberger
2003-06-07 7:11 ` David S. Miller
2003-06-10 20:01 ` David Mosberger
2003-06-12 6:47 ` David S. Miller
2003-06-15 7:06 ` Anton Blanchard
2003-06-15 7:11 ` David S. Miller
2003-06-15 8:04 ` Anton Blanchard
2003-06-15 8:18 ` David S. Miller
2003-06-07 7:20 ` David Mosberger
2003-06-07 7:19 ` David S. Miller
2003-06-07 9:44 ` Russell King
2003-06-07 9:47 ` David S. Miller
2003-06-07 13:23 ` Christoph Hellwig
2003-06-10 20:24 ` David Mosberger
2003-06-06 18:06 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200306062013.h56KDcLe026713@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=axboe@suse.de \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®