[PATCH 0/3] regulator: mcp16502: make lpm pin optional

[PATCH 0/3] regulator: mcp16502: make lpm pin optional

[Claudiu Beznea]

Hi,

This patch makes the LPM pin as optional as this may be controlled
in the last phase of suspend procedure to decrease the power consumption
while suspended. Along w/ this update the MAINTAINERS entry for this
driver.

Thank you,
Claudiu Beznea

Claudiu Beznea (3):
  dt-bindings: regulator: mcp16502: document lpm as optional
  regulator: mcp16502: lpm pin can be optional on some platforms
  MAINTAINERS: add myself as maintainer for mcp16502

 Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt | 3 ++-
 MAINTAINERS                                                        | 4 ++--
 drivers/regulator/mcp16502.c                                       | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.7.4

[PATCH 1/3] dt-bindings: regulator: mcp16502: document lpm as optional

[Claudiu Beznea]

Document LPM pin as optional.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt b/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
index d86584ed4d93..451cc4e86b01 100644
--- a/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
@@ -4,7 +4,8 @@ Required properties:
 - compatible: "microchip,mcp16502"
 - reg: I2C slave address
 - lpm-gpios: GPIO for LPM pin. Note that this GPIO *must* remain high during
-	     suspend-to-ram, keeping the PMIC into HIBERNATE mode.
+	     suspend-to-ram, keeping the PMIC into HIBERNATE mode; this
+	     property is optional;
 - regulators: A node that houses a sub-node for each regulator within
               the device. Each sub-node is identified using the node's
               name. The content of each sub-node is defined by the
-- 
2.7.4

[PATCH 2/3] regulator: mcp16502: lpm pin can be optional on some platforms

[Claudiu Beznea]

On some platform (e.g. SAMA7G5) LPM pin should be optional as it can
be controlled explicitly (via shutdown controller registers) in the
platform specific power saving code to decrease the power consumption
while suspended as this SoC pin may be connected to other devices that
could take power saving actions based on its value.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 drivers/regulator/mcp16502.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
index 74ad92dc664a..88c6bd5b6c78 100644
--- a/drivers/regulator/mcp16502.c
+++ b/drivers/regulator/mcp16502.c
@@ -550,7 +550,7 @@ static int mcp16502_probe(struct i2c_client *client,
 	config.regmap = rmap;
 	config.driver_data = mcp;
 
-	mcp->lpm = devm_gpiod_get(dev, "lpm", GPIOD_OUT_LOW);
+	mcp->lpm = devm_gpiod_get_optional(dev, "lpm", GPIOD_OUT_LOW);
 	if (IS_ERR(mcp->lpm)) {
 		dev_err(dev, "failed to get lpm pin: %ld\n", PTR_ERR(mcp->lpm));
 		return PTR_ERR(mcp->lpm);
-- 
2.7.4

[PATCH 3/3] MAINTAINERS: add myself as maintainer for mcp16502

[Claudiu Beznea]

Andrei is no longer with Microchip. Add myself as maintainer for
MCP16502. Along with this change the status from maintained to
supported.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6eff4f720c72..1cd9914b95eb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11690,9 +11690,9 @@ F:	drivers/video/fbdev/atmel_lcdfb.c
 F:	include/video/atmel_lcdc.h
 
 MICROCHIP MCP16502 PMIC DRIVER
-M:	Andrei Stefanescu <andrei.stefanescu@microchip.com>
+M:	Claudiu Beznea <claudiu.beznea@microchip.com>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-S:	Maintained
+S:	Supported
 F:	Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
 F:	drivers/regulator/mcp16502.c
 
-- 
2.7.4

Re: [PATCH 3/3] MAINTAINERS: add myself as maintainer for mcp16502

[Nicolas Ferre]

On 07/01/2021 at 15:15, Claudiu Beznea wrote:
> Andrei is no longer with Microchip. Add myself as maintainer for
> MCP16502. Along with this change the status from maintained to
> supported.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

For the record:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Claudiu!

Regards,
   Nicolas

> ---
>   MAINTAINERS | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6eff4f720c72..1cd9914b95eb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11690,9 +11690,9 @@ F:	drivers/video/fbdev/atmel_lcdfb.c
>   F:	include/video/atmel_lcdc.h
>   
>   MICROCHIP MCP16502 PMIC DRIVER
> -M:	Andrei Stefanescu <andrei.stefanescu@microchip.com>
> +M:	Claudiu Beznea <claudiu.beznea@microchip.com>
>   L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -S:	Maintained
> +S:	Supported
>   F:	Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
>   F:	drivers/regulator/mcp16502.c
>   
> 


-- 
Nicolas Ferre

Re: [PATCH 0/3] regulator: mcp16502: make lpm pin optional

[Mark Brown]

On Thu, 7 Jan 2021 16:15:24 +0200, Claudiu Beznea wrote:
> This patch makes the LPM pin as optional as this may be controlled
> in the last phase of suspend procedure to decrease the power consumption
> while suspended. Along w/ this update the MAINTAINERS entry for this
> driver.
> 
> Thank you,
> Claudiu Beznea
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/3] dt-bindings: regulator: mcp16502: document lpm as optional
      commit: eea0b4e213232b28a25de5b88af9e25667e8d2f2
[2/3] regulator: mcp16502: lpm pin can be optional on some platforms
      commit: 3c42728c18d093e8951ad6caf7daa89fa2f54702
[3/3] MAINTAINERS: add myself as maintainer for mcp16502
      commit: 8aad7fabce6ad9491cc7d23f85d9798a4a0ce399

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark