* [PATCH v1] nohz: Restart tick before do softirq
@ 2021-01-21 4:44 chenshiyan
0 siblings, 0 replies; only message in thread
From: chenshiyan @ 2021-01-21 4:44 UTC (permalink / raw)
To: fweisbec, tglx, mingo, linux-kernel
When the cpu is continuously idle, tick_irq_exit() will count next tick
expiry with maybe several periodic ticks, but if it enters softirq
before next tick, invoke_softirq() is called before tick_irq_exit(),
there will be no ticks during softirq. So with sched_clock_irqtime
closing, sirq is very low in nohz idle even if the softirq costs much
time beause of the sampling ticks missing(sirq will be much higher and
seem exact if the cpu is busy).
Signed-off-by: chenshiyan <chenshiyan@linux.alibaba.com>
---
kernel/softirq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9d71046..8f3f71b9 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -210,6 +210,7 @@ static inline void invoke_softirq(void)
return;
if (!force_irqthreads) {
+ tick_nohz_idle_restart_tick();
#ifdef CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK
/*
* We can safely execute softirq on the current stack if
--
1.8.3.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-21 4:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 4:44 [PATCH v1] nohz: Restart tick before do softirq chenshiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®