* [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon
@ 2021-02-03 2:50 Yang Li
2021-02-03 7:43 ` Uwe Kleine-König
2021-02-03 17:52 ` Vladimir Zapolskiy
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2021-02-03 2:50 UTC (permalink / raw)
To: thierry.reding
Cc: u.kleine-koenig, lee.jones, vz, linux-pwm, linux-arm-kernel,
linux-kernel, Yang Li
Eliminate the following coccicheck warning:
./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/pwm/pwm-lpc18xx-sct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c
index dc5133b..7ef4024 100644
--- a/drivers/pwm/pwm-lpc18xx-sct.c
+++ b/drivers/pwm/pwm-lpc18xx-sct.c
@@ -289,7 +289,7 @@ static int lpc18xx_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
dev_err(lpc18xx_pwm->dev,
"maximum number of simultaneous channels reached\n");
return -EBUSY;
- };
+ }
set_bit(event, &lpc18xx_pwm->event_map);
lpc18xx_data->duty_event = event;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon
2021-02-03 2:50 [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon Yang Li
@ 2021-02-03 7:43 ` Uwe Kleine-König
2021-02-03 17:52 ` Vladimir Zapolskiy
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2021-02-03 7:43 UTC (permalink / raw)
To: Yang Li
Cc: thierry.reding, lee.jones, vz, linux-pwm, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Wed, Feb 03, 2021 at 10:50:05AM +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
But this is prior art:
https://lore.kernel.org/r/20210128134537.GA54687@068c7b848bbb
This patch is better though as it doesn't have a bogus Fixes: line.
*shrug*, I let Thierry decide which one to pick up.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon
2021-02-03 2:50 [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon Yang Li
2021-02-03 7:43 ` Uwe Kleine-König
@ 2021-02-03 17:52 ` Vladimir Zapolskiy
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2021-02-03 17:52 UTC (permalink / raw)
To: Yang Li, thierry.reding
Cc: u.kleine-koenig, lee.jones, linux-pwm, linux-arm-kernel, linux-kernel
On 2/3/21 4:50 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-03 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 2:50 [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon Yang Li
2021-02-03 7:43 ` Uwe Kleine-König
2021-02-03 17:52 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®