* [PATCH] scsi: lpfc: Remove unneeded return variable
@ 2021-02-04 7:35 Yang Li
2021-02-04 9:48 ` Johannes Thumshirn
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-02-04 7:35 UTC (permalink / raw)
To: christian.koenig
Cc: sumit.semwal, martin.petersen, jejb, dick.kennedy, james.smart,
linux-scsi, linux-kernel, linux-media, dri-devel, linaro-mm-sig,
Yang Li
This patch removes unneeded return variables, using only
'1' instead.
It fixes the following warning detected by coccinelle:
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/scsi/lpfc/lpfc_sli.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 95caad7..31f97f6 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -3376,7 +3376,6 @@ struct lpfc_hbq_init *lpfc_hbq_defs[] = {
struct lpfc_iocbq *saveq)
{
struct lpfc_iocbq *cmdiocbp;
- int rc = 1;
unsigned long iflag;
cmdiocbp = lpfc_sli_iocbq_lookup(phba, pring, saveq);
@@ -3501,7 +3500,7 @@ struct lpfc_hbq_init *lpfc_hbq_defs[] = {
}
}
- return rc;
+ return 1;
}
/**
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] scsi: lpfc: Remove unneeded return variable
2021-02-04 7:35 [PATCH] scsi: lpfc: Remove unneeded return variable Yang Li
@ 2021-02-04 9:48 ` Johannes Thumshirn
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Thumshirn @ 2021-02-04 9:48 UTC (permalink / raw)
To: Yang Li, christian.koenig
Cc: sumit.semwal, martin.petersen, jejb, dick.kennedy, james.smart,
linux-scsi, linux-kernel, linux-media, dri-devel, linaro-mm-sig
On 04/02/2021 08:37, Yang Li wrote:
> This patch removes unneeded return variables, using only
> '1' instead.
> It fixes the following warning detected by coccinelle:
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 95caad7..31f97f6 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -3376,7 +3376,6 @@ struct lpfc_hbq_init *lpfc_hbq_defs[] = {
> struct lpfc_iocbq *saveq)
> {
> struct lpfc_iocbq *cmdiocbp;
> - int rc = 1;
> unsigned long iflag;
>
> cmdiocbp = lpfc_sli_iocbq_lookup(phba, pring, saveq);
> @@ -3501,7 +3500,7 @@ struct lpfc_hbq_init *lpfc_hbq_defs[] = {
> }
> }
>
> - return rc;
> + return 1;
> }
>
> /**
>
I suppose this is in 'lpfc_sli_process_sol_iocb()'. It's return
value doesn't get handled either:
case LPFC_SOL_IOCB:
spin_unlock_irqrestore(&phba->hbalock, iflag);
rc = lpfc_sli_process_sol_iocb(phba, pring, saveq);
spin_lock_irqsave(&phba->hbalock, iflag);
break;
[...]
}
if (free_saveq) {
list_for_each_entry_safe(rspiocbp, next_iocb,
&saveq->list, list) {
list_del_init(&rspiocbp->list);
__lpfc_sli_release_iocbq(phba, rspiocbp);
}
__lpfc_sli_release_iocbq(phba, saveq);
}
rspiocbp = NULL;
}
spin_unlock_irqrestore(&phba->hbalock, iflag);
return rspiocbp;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-04 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 7:35 [PATCH] scsi: lpfc: Remove unneeded return variable Yang Li
2021-02-04 9:48 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome