* [PATCH] powerpc/xive: Assign boolean values to a bool variable
@ 2021-02-07 6:43 Jiapeng Chong
2021-02-12 0:19 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-07 6:43 UTC (permalink / raw)
To: paulus; +Cc: mpe, benh, kvm-ppc, linuxppc-dev, linux-kernel, Jiapeng Chong
Fix the following coccicheck warnings:
./arch/powerpc/kvm/book3s_xive.c:1856:2-17: WARNING: Assignment of 0/1
to bool variable.
./arch/powerpc/kvm/book3s_xive.c:1854:2-17: WARNING: Assignment of 0/1
to bool variable.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
arch/powerpc/kvm/book3s_xive.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_xive.c b/arch/powerpc/kvm/book3s_xive.c
index 30dfeac..e7219b6 100644
--- a/arch/powerpc/kvm/book3s_xive.c
+++ b/arch/powerpc/kvm/book3s_xive.c
@@ -1813,9 +1813,9 @@ int kvmppc_xive_set_irq(struct kvm *kvm, int irq_source_id, u32 irq, int level,
return -EINVAL;
if ((level == 1 && state->lsi) || level == KVM_INTERRUPT_SET_LEVEL)
- state->asserted = 1;
+ state->asserted = true;
else if (level == 0 || level == KVM_INTERRUPT_UNSET) {
- state->asserted = 0;
+ state->asserted = false;
return 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/xive: Assign boolean values to a bool variable
2021-02-07 6:43 [PATCH] powerpc/xive: Assign boolean values to a bool variable Jiapeng Chong
@ 2021-02-12 0:19 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-02-12 0:19 UTC (permalink / raw)
To: paulus, Jiapeng Chong; +Cc: kvm-ppc, linux-kernel, linuxppc-dev
On Sun, 7 Feb 2021 14:43:12 +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./arch/powerpc/kvm/book3s_xive.c:1856:2-17: WARNING: Assignment of 0/1
> to bool variable.
>
> ./arch/powerpc/kvm/book3s_xive.c:1854:2-17: WARNING: Assignment of 0/1
> to bool variable.
Applied to powerpc/next.
[1/1] powerpc/xive: Assign boolean values to a bool variable
https://git.kernel.org/powerpc/c/c9df3f809cc98b196548864f52d3c4e280dd1970
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-12 0:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-07 6:43 [PATCH] powerpc/xive: Assign boolean values to a bool variable Jiapeng Chong
2021-02-12 0:19 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®