mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] vfio: platform: ignore missing reset if disabled at module init
@ 2023-01-25 16:11 Tomasz Duszynski
  2023-01-30  9:05 ` Tian, Kevin
  0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Duszynski @ 2023-01-25 16:11 UTC (permalink / raw)
  To: Eric Auger, Alex Williamson, Cornelia Huck, Kevin Tian,
	Jason Gunthorpe, open list:VFIO PLATFORM DRIVER, open list
  Cc: jerinj, Tomasz Duszynski

If reset requirement was relaxed via module parameter errors caused by
missing reset should not be propagated down to the vfio core.
Otherwise initialization will fail.

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
Fixes: 5f6c7e0831a1 ("vfio/platform: Use the new device life cycle helpers")
---
 drivers/vfio/platform/vfio_platform_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index 1a0a238ffa35..c09ffab6fbe6 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -653,7 +653,8 @@ int vfio_platform_init_common(struct vfio_platform_device *vdev)
 	if (ret && vdev->reset_required)
 		dev_err(dev, "No reset function found for device %s\n",
 			vdev->name);
-	return ret;
+
+	return vdev->reset_required ? ret : 0;
 }
 EXPORT_SYMBOL_GPL(vfio_platform_init_common);
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-30 12:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 16:11 [PATCH] vfio: platform: ignore missing reset if disabled at module init Tomasz Duszynski
2023-01-30  9:05 ` Tian, Kevin
2023-01-30  9:53   ` Eric Auger
2023-01-30 12:31   ` Tomasz Duszynski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®