[net-next 0/4] net: mvpp2: Minor non functional driver code improvements

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [net-next 0/4] net: mvpp2: Minor non functional driver code improvements
@ 2021-02-14 13:38 stefanc
  2021-02-14 13:38 ` [net-next 1/4] net: mvpp2: simplify PPv2 version ID read stefanc
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: stefanc @ 2021-02-14 13:38 UTC (permalink / raw)
  To: netdev
  Cc: thomas.petazzoni, davem, nadavh, ymarkman, linux-kernel, stefanc,
	kuba, linux, mw, andrew, rmk+kernel, atenart

From: Stefan Chulski <stefanc@marvell.com>

The patch series contains minor code improvements and did not change any functionality.

Stefan Chulski (4):
  net: mvpp2: simplify PPv2 version ID read
  net: mvpp2: improve Packet Processor version check
  net: mvpp2: improve mvpp2_get_sram return
  net: mvpp2: improve Networking Complex Control register naming

 drivers/net/ethernet/marvell/mvpp2/mvpp2.h      |  6 +--
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 52 +++++++++-----------
 2 files changed, 27 insertions(+), 31 deletions(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [net-next 1/4] net: mvpp2: simplify PPv2 version ID read
  2021-02-14 13:38 [net-next 0/4] net: mvpp2: Minor non functional driver code improvements stefanc
@ 2021-02-14 13:38 ` stefanc
  2021-02-14 13:38 ` [net-next 2/4] net: mvpp2: improve Packet Processor version check stefanc
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: stefanc @ 2021-02-14 13:38 UTC (permalink / raw)
  To: netdev
  Cc: thomas.petazzoni, davem, nadavh, ymarkman, linux-kernel, stefanc,
	kuba, linux, mw, andrew, rmk+kernel, atenart

From: Stefan Chulski <stefanc@marvell.com>

PPv2.1 contain 0 in Version ID register, priv->hw_version check
can be removed.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index e88272f..9127dc2 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -7469,10 +7469,8 @@ static int mvpp2_probe(struct platform_device *pdev)
 			priv->port_map |= BIT(i);
 	}
 
-	if (priv->hw_version != MVPP21) {
-		if (mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23)
-			priv->hw_version = MVPP23;
-	}
+	if (mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23)
+		priv->hw_version = MVPP23;
 
 	/* Init mss lock */
 	spin_lock_init(&priv->mss_spinlock);
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [net-next 2/4] net: mvpp2: improve Packet Processor version check
  2021-02-14 13:38 [net-next 0/4] net: mvpp2: Minor non functional driver code improvements stefanc
  2021-02-14 13:38 ` [net-next 1/4] net: mvpp2: simplify PPv2 version ID read stefanc
@ 2021-02-14 13:38 ` stefanc
  2021-02-14 13:38 ` [net-next 3/4] net: mvpp2: improve mvpp2_get_sram return stefanc
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: stefanc @ 2021-02-14 13:38 UTC (permalink / raw)
  To: netdev
  Cc: thomas.petazzoni, davem, nadavh, ymarkman, linux-kernel, stefanc,
	kuba, linux, mw, andrew, rmk+kernel, atenart

From: Stefan Chulski <stefanc@marvell.com>

Use >= MVPP22 instead of != MVPP21.
Non functional change.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 36 ++++++++++----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 9127dc2..4e1a24c 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -329,7 +329,7 @@ static int mvpp2_get_nrxqs(struct mvpp2 *priv)
 {
 	unsigned int nrxqs;
 
-	if (priv->hw_version != MVPP21 && queue_mode == MVPP2_QDIST_SINGLE_MODE)
+	if (priv->hw_version >= MVPP22 && queue_mode == MVPP2_QDIST_SINGLE_MODE)
 		return 1;
 
 	/* According to the PPv2.2 datasheet and our experiments on
@@ -469,7 +469,7 @@ static void mvpp2_bm_bufs_get_addrs(struct device *dev, struct mvpp2 *priv,
 				      MVPP2_BM_PHY_ALLOC_REG(bm_pool->id));
 	*phys_addr = mvpp2_thread_read(priv, thread, MVPP2_BM_VIRT_ALLOC_REG);
 
-	if (priv->hw_version != MVPP21) {
+	if (priv->hw_version >= MVPP22) {
 		u32 val;
 		u32 dma_addr_highbits, phys_addr_highbits;
 
@@ -963,7 +963,7 @@ static inline void mvpp2_bm_pool_put(struct mvpp2_port *port, int pool,
 	if (test_bit(thread, &port->priv->lock_map))
 		spin_lock_irqsave(&port->bm_lock[thread], flags);
 
-	if (port->priv->hw_version != MVPP21) {
+	if (port->priv->hw_version >= MVPP22) {
 		u32 val = 0;
 
 		if (sizeof(dma_addr_t) == 8)
@@ -1462,7 +1462,7 @@ static bool mvpp2_port_supports_xlg(struct mvpp2_port *port)
 
 static bool mvpp2_port_supports_rgmii(struct mvpp2_port *port)
 {
-	return !(port->priv->hw_version != MVPP21 && port->gop_id == 0);
+	return !(port->priv->hw_version >= MVPP22 && port->gop_id == 0);
 }
 
 /* Port configuration routines */
@@ -2125,7 +2125,7 @@ static void mvpp2_mac_reset_assert(struct mvpp2_port *port)
 	      MVPP2_GMAC_PORT_RESET_MASK;
 	writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
 
-	if (port->priv->hw_version != MVPP21 && port->gop_id == 0) {
+	if (port->priv->hw_version >= MVPP22 && port->gop_id == 0) {
 		val = readl(port->base + MVPP22_XLG_CTRL0_REG) &
 		      ~MVPP22_XLG_CTRL0_MAC_RESET_DIS;
 		writel(val, port->base + MVPP22_XLG_CTRL0_REG);
@@ -4016,7 +4016,7 @@ static void mvpp2_txdesc_clear_ptp(struct mvpp2_port *port,
 				   struct mvpp2_tx_desc *desc)
 {
 	/* We only need to clear the low bits */
-	if (port->priv->hw_version != MVPP21)
+	if (port->priv->hw_version >= MVPP22)
 		desc->pp22.ptp_descriptor &=
 			cpu_to_le32(~MVPP22_PTP_DESC_MASK_LOW);
 }
@@ -4528,7 +4528,7 @@ static void mvpp2_start_dev(struct mvpp2_port *port)
 	/* Enable interrupts on all threads */
 	mvpp2_interrupts_enable(port);
 
-	if (port->priv->hw_version != MVPP21)
+	if (port->priv->hw_version >= MVPP22)
 		mvpp22_mode_reconfigure(port);
 
 	if (port->phylink) {
@@ -4746,7 +4746,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version != MVPP21 && port->port_irq) {
+	if (priv->hw_version >= MVPP22 && port->port_irq) {
 		err = request_irq(port->port_irq, mvpp2_port_isr, 0,
 				  dev->name, port);
 		if (err) {
@@ -6399,7 +6399,7 @@ static int mvpp2__mac_prepare(struct phylink_config *config, unsigned int mode,
 			     MVPP2_GMAC_PORT_RESET_MASK,
 			     MVPP2_GMAC_PORT_RESET_MASK);
 
-		if (port->priv->hw_version != MVPP21) {
+		if (port->priv->hw_version >= MVPP22) {
 			mvpp22_gop_mask_irq(port);
 
 			phy_power_off(port->comphy);
@@ -6453,7 +6453,7 @@ static int mvpp2_mac_finish(struct phylink_config *config, unsigned int mode,
 {
 	struct mvpp2_port *port = mvpp2_phylink_to_port(config);
 
-	if (port->priv->hw_version != MVPP21 &&
+	if (port->priv->hw_version >= MVPP22 &&
 	    port->phy_interface != interface) {
 		port->phy_interface = interface;
 
@@ -7200,7 +7200,7 @@ static int mvpp2_init(struct platform_device *pdev, struct mvpp2 *priv)
 	if (dram_target_info)
 		mvpp2_conf_mbus_windows(dram_target_info, priv);
 
-	if (priv->hw_version != MVPP21)
+	if (priv->hw_version >= MVPP22)
 		mvpp2_axi_init(priv);
 
 	/* Disable HW PHY polling */
@@ -7350,7 +7350,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 			priv->global_tx_fc = true;
 	}
 
-	if (priv->hw_version != MVPP21 && dev_of_node(&pdev->dev)) {
+	if (priv->hw_version >= MVPP22 && dev_of_node(&pdev->dev)) {
 		priv->sysctrl_base =
 			syscon_regmap_lookup_by_phandle(pdev->dev.of_node,
 							"marvell,system-controller");
@@ -7363,7 +7363,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 			priv->sysctrl_base = NULL;
 	}
 
-	if (priv->hw_version != MVPP21 &&
+	if (priv->hw_version >= MVPP22 &&
 	    mvpp2_get_nrxqs(priv) * 2 <= MVPP2_BM_MAX_POOLS)
 		priv->percpu_pools = 1;
 
@@ -7408,7 +7408,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 		if (err < 0)
 			goto err_pp_clk;
 
-		if (priv->hw_version != MVPP21) {
+		if (priv->hw_version >= MVPP22) {
 			priv->mg_clk = devm_clk_get(&pdev->dev, "mg_clk");
 			if (IS_ERR(priv->mg_clk)) {
 				err = PTR_ERR(priv->mg_clk);
@@ -7449,7 +7449,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	if (priv->hw_version != MVPP21) {
+	if (priv->hw_version >= MVPP22) {
 		err = dma_set_mask(&pdev->dev, MVPP2_DESC_DMA_MASK);
 		if (err)
 			goto err_axi_clk;
@@ -7514,7 +7514,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 		goto err_port_probe;
 	}
 
-	if (priv->global_tx_fc && priv->hw_version != MVPP21) {
+	if (priv->global_tx_fc && priv->hw_version >= MVPP22) {
 		err = mvpp2_enable_global_fc(priv);
 		if (err)
 			dev_warn(&pdev->dev, "Minimum of CM3 firmware 18.09 and chip revision B0 required for flow control\n");
@@ -7536,10 +7536,10 @@ static int mvpp2_probe(struct platform_device *pdev)
 	clk_disable_unprepare(priv->axi_clk);
 
 err_mg_core_clk:
-	if (priv->hw_version != MVPP21)
+	if (priv->hw_version >= MVPP22)
 		clk_disable_unprepare(priv->mg_core_clk);
 err_mg_clk:
-	if (priv->hw_version != MVPP21)
+	if (priv->hw_version >= MVPP22)
 		clk_disable_unprepare(priv->mg_clk);
 err_gop_clk:
 	clk_disable_unprepare(priv->gop_clk);
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [net-next 3/4] net: mvpp2: improve mvpp2_get_sram return
  2021-02-14 13:38 [net-next 0/4] net: mvpp2: Minor non functional driver code improvements stefanc
  2021-02-14 13:38 ` [net-next 1/4] net: mvpp2: simplify PPv2 version ID read stefanc
  2021-02-14 13:38 ` [net-next 2/4] net: mvpp2: improve Packet Processor version check stefanc
@ 2021-02-14 13:38 ` stefanc
  2021-02-14 13:38 ` [net-next 4/4] net: mvpp2: improve Networking Complex Control register naming stefanc
  2021-02-15 20:40 ` [net-next 0/4] net: mvpp2: Minor non functional driver code improvements patchwork-bot+netdevbpf
  4 siblings, 0 replies; 6+ messages in thread
From: stefanc @ 2021-02-14 13:38 UTC (permalink / raw)
  To: netdev
  Cc: thomas.petazzoni, davem, nadavh, ymarkman, linux-kernel, stefanc,
	kuba, linux, mw, andrew, rmk+kernel, atenart

From: Stefan Chulski <stefanc@marvell.com>

Use PTR_ERR_OR_ZERO instead of IS_ERR and PTR_ERR.
Non functional change.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 4e1a24c..bc98f52 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -7277,10 +7277,8 @@ static int mvpp2_get_sram(struct platform_device *pdev,
 	}
 
 	priv->cm3_base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(priv->cm3_base))
-		return PTR_ERR(priv->cm3_base);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(priv->cm3_base);
 }
 
 static int mvpp2_probe(struct platform_device *pdev)
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [net-next 4/4] net: mvpp2: improve Networking Complex Control register naming
  2021-02-14 13:38 [net-next 0/4] net: mvpp2: Minor non functional driver code improvements stefanc
                   ` (2 preceding siblings ...)
  2021-02-14 13:38 ` [net-next 3/4] net: mvpp2: improve mvpp2_get_sram return stefanc
@ 2021-02-14 13:38 ` stefanc
  2021-02-15 20:40 ` [net-next 0/4] net: mvpp2: Minor non functional driver code improvements patchwork-bot+netdevbpf
  4 siblings, 0 replies; 6+ messages in thread
From: stefanc @ 2021-02-14 13:38 UTC (permalink / raw)
  To: netdev
  Cc: thomas.petazzoni, davem, nadavh, ymarkman, linux-kernel, stefanc,
	kuba, linux, mw, andrew, rmk+kernel, atenart

From: Stefan Chulski <stefanc@marvell.com>

GENCONF_CTRL0_PORTX naming improved.
Non functional change.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2.h      | 6 +++---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
index da87152..373ede3 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
@@ -673,9 +673,9 @@
 #define     GENCONF_PORT_CTRL1_EN(p)			BIT(p)
 #define     GENCONF_PORT_CTRL1_RESET(p)			(BIT(p) << 28)
 #define GENCONF_CTRL0					0x1120
-#define     GENCONF_CTRL0_PORT0_RGMII			BIT(0)
-#define     GENCONF_CTRL0_PORT1_RGMII_MII		BIT(1)
-#define     GENCONF_CTRL0_PORT1_RGMII			BIT(2)
+#define     GENCONF_CTRL0_PORT2_RGMII			BIT(0)
+#define     GENCONF_CTRL0_PORT3_RGMII_MII		BIT(1)
+#define     GENCONF_CTRL0_PORT3_RGMII			BIT(2)
 
 /* Various constants */
 
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index bc98f52..d167cfd 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -1494,9 +1494,9 @@ static void mvpp22_gop_init_rgmii(struct mvpp2_port *port)
 
 	regmap_read(priv->sysctrl_base, GENCONF_CTRL0, &val);
 	if (port->gop_id == 2)
-		val |= GENCONF_CTRL0_PORT0_RGMII;
+		val |= GENCONF_CTRL0_PORT2_RGMII;
 	else if (port->gop_id == 3)
-		val |= GENCONF_CTRL0_PORT1_RGMII_MII;
+		val |= GENCONF_CTRL0_PORT3_RGMII_MII;
 	regmap_write(priv->sysctrl_base, GENCONF_CTRL0, val);
 }
 
@@ -1513,9 +1513,9 @@ static void mvpp22_gop_init_sgmii(struct mvpp2_port *port)
 	if (port->gop_id > 1) {
 		regmap_read(priv->sysctrl_base, GENCONF_CTRL0, &val);
 		if (port->gop_id == 2)
-			val &= ~GENCONF_CTRL0_PORT0_RGMII;
+			val &= ~GENCONF_CTRL0_PORT2_RGMII;
 		else if (port->gop_id == 3)
-			val &= ~GENCONF_CTRL0_PORT1_RGMII_MII;
+			val &= ~GENCONF_CTRL0_PORT3_RGMII_MII;
 		regmap_write(priv->sysctrl_base, GENCONF_CTRL0, val);
 	}
 }
-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [net-next 0/4] net: mvpp2: Minor non functional driver code improvements
  2021-02-14 13:38 [net-next 0/4] net: mvpp2: Minor non functional driver code improvements stefanc
                   ` (3 preceding siblings ...)
  2021-02-14 13:38 ` [net-next 4/4] net: mvpp2: improve Networking Complex Control register naming stefanc
@ 2021-02-15 20:40 ` patchwork-bot+netdevbpf
  4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-15 20:40 UTC (permalink / raw)
  To: Stefan Chulski
  Cc: netdev, thomas.petazzoni, davem, nadavh, ymarkman, linux-kernel,
	kuba, linux, mw, andrew, rmk+kernel, atenart

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sun, 14 Feb 2021 15:38:33 +0200 you wrote:
> From: Stefan Chulski <stefanc@marvell.com>
> 
> The patch series contains minor code improvements and did not change any functionality.
> 
> Stefan Chulski (4):
>   net: mvpp2: simplify PPv2 version ID read
>   net: mvpp2: improve Packet Processor version check
>   net: mvpp2: improve mvpp2_get_sram return
>   net: mvpp2: improve Networking Complex Control register naming
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] net: mvpp2: simplify PPv2 version ID read
    https://git.kernel.org/netdev/net-next/c/8b986866b252
  - [net-next,2/4] net: mvpp2: improve Packet Processor version check
    https://git.kernel.org/netdev/net-next/c/f704177e4721
  - [net-next,3/4] net: mvpp2: improve mvpp2_get_sram return
    https://git.kernel.org/netdev/net-next/c/9ad78d81cb76
  - [net-next,4/4] net: mvpp2: improve Networking Complex Control register naming
    https://git.kernel.org/netdev/net-next/c/935a11845aef

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-15 20:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-14 13:38 [net-next 0/4] net: mvpp2: Minor non functional driver code improvements stefanc
2021-02-14 13:38 ` [net-next 1/4] net: mvpp2: simplify PPv2 version ID read stefanc
2021-02-14 13:38 ` [net-next 2/4] net: mvpp2: improve Packet Processor version check stefanc
2021-02-14 13:38 ` [net-next 3/4] net: mvpp2: improve mvpp2_get_sram return stefanc
2021-02-14 13:38 ` [net-next 4/4] net: mvpp2: improve Networking Complex Control register naming stefanc
2021-02-15 20:40 ` [net-next 0/4] net: mvpp2: Minor non functional driver code improvements patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®