* [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put()
@ 2021-02-25 9:17 Yang Li
2021-03-02 12:40 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-02-25 9:17 UTC (permalink / raw)
To: p.zabel; +Cc: vkoul, kishon, linux-kernel, Yang Li
In one of the error paths of the for_each_child_of_node() loop in
of_property_read_u32, add missing call to of_node_put().
Fix the following coccicheck warning:
./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 795.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/phy/ti/phy-j721e-wiz.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index c9cfafe..448d8d1 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -789,6 +789,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
ret = of_property_read_u32(subnode, "reg", ®);
if (ret) {
+ of_node_put(subnode);
dev_err(dev,
"%s: Reading \"reg\" from \"%s\" failed: %d\n",
__func__, subnode->name, ret);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put()
2021-02-25 9:17 [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put() Yang Li
@ 2021-03-02 12:40 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-03-02 12:40 UTC (permalink / raw)
To: Yang Li; +Cc: p.zabel, kishon, linux-kernel
On 25-02-21, 17:17, Yang Li wrote:
> In one of the error paths of the for_each_child_of_node() loop in
> of_property_read_u32, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 795.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-02 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 9:17 [PATCH] phy: ti: j721e-wiz: add missing call to of_node_put() Yang Li
2021-03-02 12:40 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®