* [PATCH] RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool
@ 2021-02-25 9:26 Jiapeng Chong
2021-02-25 14:24 ` Tom Talpey
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-25 9:26 UTC (permalink / raw)
To: mike.marciniszyn
Cc: dennis.dalessandro, dledford, jgg, linux-rdma, linux-kernel,
Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/infiniband/hw/hfi1/tid_rdma.c:1118:36-41: WARNING: conversion
to bool not needed here.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/infiniband/hw/hfi1/tid_rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c
index 0b1f9e4..8958ea3 100644
--- a/drivers/infiniband/hw/hfi1/tid_rdma.c
+++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
@@ -1115,7 +1115,7 @@ static u32 kern_find_pages(struct tid_rdma_flow *flow,
}
flow->length = flow->req->seg_len - length;
- *last = req->isge == ss->num_sge ? false : true;
+ *last = req->isge == !ss->num_sge;
return i;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool
2021-02-25 9:26 [PATCH] RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool Jiapeng Chong
@ 2021-02-25 14:24 ` Tom Talpey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Talpey @ 2021-02-25 14:24 UTC (permalink / raw)
To: Jiapeng Chong, mike.marciniszyn
Cc: dennis.dalessandro, dledford, jgg, linux-rdma, linux-kernel
On 2/25/2021 4:26 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/infiniband/hw/hfi1/tid_rdma.c:1118:36-41: WARNING: conversion
> to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/infiniband/hw/hfi1/tid_rdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c
> index 0b1f9e4..8958ea3 100644
> --- a/drivers/infiniband/hw/hfi1/tid_rdma.c
> +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
> @@ -1115,7 +1115,7 @@ static u32 kern_find_pages(struct tid_rdma_flow *flow,
> }
>
> flow->length = flow->req->seg_len - length;
> - *last = req->isge == ss->num_sge ? false : true;
> + *last = req->isge == !ss->num_sge;
Are you sure this is what you want? The new code seems to compare
an index to a bool (refactoring)
*last = req->isge == (ss->num_sge != 0);
Don't you actually want
*last = req->isge != ss->num_sge;
??
Even then, it seems really hard to read.
> return i;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-25 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 9:26 [PATCH] RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool Jiapeng Chong
2021-02-25 14:24 ` Tom Talpey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®