* [PATCH] scsi: csiostor: Assign boolean values to a bool variable
@ 2021-03-09 9:37 Jiapeng Chong
2021-03-19 3:46 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-09 9:37 UTC (permalink / raw)
To: jejb
Cc: martin.petersen, sumit.semwal, christian.koenig, linux-scsi,
linux-kernel, linux-media, dri-devel, linaro-mm-sig,
Jiapeng Chong
Fix the following coccicheck warnings:
./drivers/scsi/csiostor/csio_scsi.c:150:9-10: WARNING: return of 0/1 in
function 'csio_scsi_itnexus_loss_error' with return type bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/csiostor/csio_scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
index 55e74da..56b9ad0 100644
--- a/drivers/scsi/csiostor/csio_scsi.c
+++ b/drivers/scsi/csiostor/csio_scsi.c
@@ -147,9 +147,9 @@ static int csio_do_abrt_cls(struct csio_hw *,
case FW_ERR_RDEV_LOST:
case FW_ERR_RDEV_LOGO:
case FW_ERR_RDEV_IMPL_LOGO:
- return 1;
+ return true;
}
- return 0;
+ return false;
}
/*
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: csiostor: Assign boolean values to a bool variable
2021-03-09 9:37 [PATCH] scsi: csiostor: Assign boolean values to a bool variable Jiapeng Chong
@ 2021-03-19 3:46 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-03-19 3:46 UTC (permalink / raw)
To: Jiapeng Chong, jejb
Cc: Martin K . Petersen, sumit.semwal, christian.koenig, dri-devel,
linux-kernel, linux-media, linux-scsi, linaro-mm-sig
On Tue, 9 Mar 2021 17:37:48 +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/scsi/csiostor/csio_scsi.c:150:9-10: WARNING: return of 0/1 in
> function 'csio_scsi_itnexus_loss_error' with return type bool.
Applied to 5.13/scsi-queue, thanks!
[1/1] scsi: csiostor: Assign boolean values to a bool variable
https://git.kernel.org/mkp/scsi/c/2ed0fc2b9a79
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-19 3:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 9:37 [PATCH] scsi: csiostor: Assign boolean values to a bool variable Jiapeng Chong
2021-03-19 3:46 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®