* [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally
@ 2021-03-16 14:03 Geert Uytterhoeven
2021-03-16 16:35 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 14:03 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Florian Fainelli,
Rafał Miłecki
Cc: bcm-kernel-feedback-list, netdev, linux-kernel, Geert Uytterhoeven
Merely enabling compile-testing should not enable additional code.
To fix this, restrict the automatic enabling of BCM4908_ENET to
ARCH_BCM4908.
Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Enable by default if ARCH_BCM4908.
---
drivers/net/ethernet/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index f8a168b73307c03b..cb88ffb8f12fa7ef 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -54,7 +54,7 @@ config B44_PCI
config BCM4908_ENET
tristate "Broadcom BCM4908 internal mac support"
depends on ARCH_BCM4908 || COMPILE_TEST
- default y
+ default y if ARCH_BCM4908
help
This driver supports Ethernet controller integrated into Broadcom
BCM4908 family SoCs.
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally
2021-03-16 14:03 [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally Geert Uytterhoeven
@ 2021-03-16 16:35 ` Florian Fainelli
2021-03-16 21:34 ` Rafał Miłecki
2021-03-16 22:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-03-16 16:35 UTC (permalink / raw)
To: Geert Uytterhoeven, David S . Miller, Jakub Kicinski,
Florian Fainelli, Rafał Miłecki
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
On 3/16/2021 7:03 AM, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional code.
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally
2021-03-16 14:03 [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally Geert Uytterhoeven
2021-03-16 16:35 ` Florian Fainelli
@ 2021-03-16 21:34 ` Rafał Miłecki
2021-03-16 22:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2021-03-16 21:34 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Jakub Kicinski, Florian Fainelli,
bcm-kernel-feedback-list, netdev, linux-kernel
On 2021-03-16 15:03, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional code.
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908
> controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally
2021-03-16 14:03 [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally Geert Uytterhoeven
2021-03-16 16:35 ` Florian Fainelli
2021-03-16 21:34 ` Rafał Miłecki
@ 2021-03-16 22:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-16 22:40 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: davem, kuba, f.fainelli, rafal, bcm-kernel-feedback-list, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 16 Mar 2021 15:03:41 +0100 you wrote:
> Merely enabling compile-testing should not enable additional code.
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> [...]
Here is the summary with links:
- [v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally
https://git.kernel.org/netdev/net/c/a3bc48321665
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-17 1:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 14:03 [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally Geert Uytterhoeven
2021-03-16 16:35 ` Florian Fainelli
2021-03-16 21:34 ` Rafał Miłecki
2021-03-16 22:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®