* [PATCH] ftrace: Modify parameter transfer type
@ 2021-03-30 10:02 Jiapeng Chong
2021-03-30 13:39 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-30 10:02 UTC (permalink / raw)
To: rostedt; +Cc: mingo, linux-kernel, Jiapeng Chong
Fix the following whitescan warning:
"order" is passed to a parameter that cannot be negative.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/trace/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index b7e29db..bd42e86 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -6811,7 +6811,7 @@ void ftrace_free_mem(struct module *mod, void *start_ptr, void *end_ptr)
if (!pg->index) {
*last_pg = pg->next;
order = get_count_order(pg->size / ENTRIES_PER_PAGE);
- free_pages((unsigned long)pg->records, order);
+ free_pages((unsigned long)pg->records, (unsigned int)order);
ftrace_number_of_pages -= 1 << order;
ftrace_number_of_groups--;
kfree(pg);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ftrace: Modify parameter transfer type
2021-03-30 10:02 [PATCH] ftrace: Modify parameter transfer type Jiapeng Chong
@ 2021-03-30 13:39 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2021-03-30 13:39 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: mingo, linux-kernel
On Tue, 30 Mar 2021 18:02:26 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Fix the following whitescan warning:
>
> "order" is passed to a parameter that cannot be negative.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index b7e29db..bd42e86 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -6811,7 +6811,7 @@ void ftrace_free_mem(struct module *mod, void *start_ptr, void *end_ptr)
> if (!pg->index) {
> *last_pg = pg->next;
> order = get_count_order(pg->size / ENTRIES_PER_PAGE);
> - free_pages((unsigned long)pg->records, order);
> + free_pages((unsigned long)pg->records, (unsigned int)order);
NAK!
This "fix" actually makes the problem worse, and hides a possible bug.
-- Steve
> ftrace_number_of_pages -= 1 << order;
> ftrace_number_of_groups--;
> kfree(pg);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-30 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 10:02 [PATCH] ftrace: Modify parameter transfer type Jiapeng Chong
2021-03-30 13:39 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®