* [PATCH] cifs: Remove useless variable
@ 2021-04-08 8:31 Jiapeng Chong
2021-04-09 4:09 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-08 8:31 UTC (permalink / raw)
To: sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, Jiapeng Chong
Fix the following gcc warning:
fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used
[-Wunused-but-set-variable].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/cifs/cifsacl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
index d178cf8..fdb258a 100644
--- a/fs/cifs/cifsacl.c
+++ b/fs/cifs/cifsacl.c
@@ -1094,11 +1094,9 @@ static int set_chmod_dacl(struct cifs_acl *pdacl, struct cifs_acl *pndacl,
struct cifs_ace *pnntace = NULL;
char *nacl_base = NULL;
u32 num_aces = 0;
- __u64 nmode;
bool new_aces_set = false;
/* Assuming that pndacl and pnmode are never NULL */
- nmode = *pnmode;
nacl_base = (char *)pndacl;
nsize = sizeof(struct cifs_acl);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cifs: Remove useless variable
2021-04-08 8:31 [PATCH] cifs: Remove useless variable Jiapeng Chong
@ 2021-04-09 4:09 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2021-04-09 4:09 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: Steve French, CIFS, samba-technical, LKML
merged into cifs-2.6.git for-next
On Thu, Apr 8, 2021 at 3:33 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following gcc warning:
>
> fs/cifs/cifsacl.c:1097:8: warning: variable ‘nmode’ set but not used
> [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/cifs/cifsacl.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
> index d178cf8..fdb258a 100644
> --- a/fs/cifs/cifsacl.c
> +++ b/fs/cifs/cifsacl.c
> @@ -1094,11 +1094,9 @@ static int set_chmod_dacl(struct cifs_acl *pdacl, struct cifs_acl *pndacl,
> struct cifs_ace *pnntace = NULL;
> char *nacl_base = NULL;
> u32 num_aces = 0;
> - __u64 nmode;
> bool new_aces_set = false;
>
> /* Assuming that pndacl and pnmode are never NULL */
> - nmode = *pnmode;
> nacl_base = (char *)pndacl;
> nsize = sizeof(struct cifs_acl);
>
> --
> 1.8.3.1
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 4:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 8:31 [PATCH] cifs: Remove useless variable Jiapeng Chong
2021-04-09 4:09 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®