From: Mikael Pettersson <mikpe@csd.uu.se>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Dave Jones <davej@codemonkey.org.uk>,
torvalds@transmeta.com, fxkuehl@gmx.de,
linux-kernel@vger.kernel.org, willy@w.ods.org
Subject: Re: [PATCH][2.6.0-test3] Disable APIC on reboot.
Date: Tue, 12 Aug 2003 15:57:22 +0200 [thread overview]
Message-ID: <16184.62018.545010.839328@gargle.gargle.HOWL> (raw)
In-Reply-To: <Pine.GSO.3.96.1030812154705.7029B-100000@delta.ds2.pg.gda.pl>
Maciej W. Rozycki writes:
> On Tue, 12 Aug 2003, Mikael Pettersson wrote:
>
> > @@ -249,6 +250,14 @@
> > * other OSs see a clean IRQ state.
> > */
> > smp_send_stop();
> > +#elif CONFIG_X86_LOCAL_APIC
> > + if (cpu_has_apic) {
> > + local_irq_disable();
> > + disable_local_APIC();
> > + local_irq_enable();
> > + }
> > +#endif
> > +#ifdef CONFIG_X86_IO_APIC
> > disable_IO_APIC();
> > #endif
>
> You obviously want to disable I/O APICs first.
This follows the same order that the SMP reboot code has been using
for ages. I did check disable_IO_APIC(), and it does not depend on
the BP's local APIC being enabled.
I don't think there is a bug, but if there is, it's in the original
code too (simply trace what an SMP kernel on UP_IOAPIC HW would do).
/Mikael
next prev parent reply other threads:[~2003-08-12 13:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 13:40 [PATCH] " davej
2003-08-11 15:33 ` [PATCH-2.4] " Willy Tarreau
2003-08-11 16:29 ` [PATCH] " Mikael Pettersson
2003-08-11 16:38 ` Dave Jones
2003-08-11 16:57 ` Mikael Pettersson
2003-08-11 23:33 ` [PATCH][2.6.0-test3] " Mikael Pettersson
2003-08-12 13:48 ` Maciej W. Rozycki
2003-08-12 13:57 ` Mikael Pettersson [this message]
2003-08-12 14:31 ` Maciej W. Rozycki
2003-08-11 23:33 ` [PATCH][2.4.22-rc2] " Mikael Pettersson
2003-08-12 6:09 ` Willy Tarreau
2003-08-15 19:22 ` Marc-Christian Petersen
2003-08-27 7:19 ` Luca Montecchiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16184.62018.545010.839328@gargle.gargle.HOWL \
--to=mikpe@csd.uu.se \
--cc=davej@codemonkey.org.uk \
--cc=fxkuehl@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=torvalds@transmeta.com \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®