From: Marc-Christian Petersen <m.c.p@wolk-project.de>
To: Mikael Pettersson <mikpe@csd.uu.se>,
Dave Jones <davej@codemonkey.org.uk>
Cc: marcelo@conectiva.com.br, fxkuehl@gmx.de,
linux-kernel@vger.kernel.org, willy@w.ods.org
Subject: Re: [PATCH][2.4.22-rc2] Disable APIC on reboot.
Date: Fri, 15 Aug 2003 21:22:10 +0200 [thread overview]
Message-ID: <200308152121.44027.m.c.p@wolk-project.de> (raw)
In-Reply-To: <16184.10173.412201.802953@gargle.gargle.HOWL>
On Tuesday 12 August 2003 01:33, Mikael Pettersson wrote:
Hi Mikael,
> disable_local_APIC() now checks if detect_init_APIC() enabled the
> local APIC via the APIC_BASE MSR, and if so it now disables APIC_BASE.
> Previously we would leave APIC_BASE enabled, and that made some
> BIOSen unhappy.
> The SMP reboot code calls disable_local_APIC(). On SMP HW there is
> no change since detect_init_APIC() isn't called and APIC_BASE isn't
> enabled by us. An SMP kernel on UP HW behaves just like an UP_APIC
> kernel, so it disables APIC_BASE if we enabled it at boot.
> The UP_APIC disable-before-suspend code is simplified since the existing
> code to disable APIC_BASE is moved into disable_local_APIC().
> (Felix Kühling originally reported the BIOS reboot problem. This is a
> fixed-up version of his preliminary patch.)
please correct me if I say something really stupid now but shouldn't the APIC
be disabled only during reboot time and enabled again at a new boot?
my experience with this patch is, after a reboot he APIC isn't enabled again
until I power off my machine.
ciao, Marc
next prev parent reply other threads:[~2003-08-15 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 13:40 [PATCH] " davej
2003-08-11 15:33 ` [PATCH-2.4] " Willy Tarreau
2003-08-11 16:29 ` [PATCH] " Mikael Pettersson
2003-08-11 16:38 ` Dave Jones
2003-08-11 16:57 ` Mikael Pettersson
2003-08-11 23:33 ` [PATCH][2.6.0-test3] " Mikael Pettersson
2003-08-12 13:48 ` Maciej W. Rozycki
2003-08-12 13:57 ` Mikael Pettersson
2003-08-12 14:31 ` Maciej W. Rozycki
2003-08-11 23:33 ` [PATCH][2.4.22-rc2] " Mikael Pettersson
2003-08-12 6:09 ` Willy Tarreau
2003-08-15 19:22 ` Marc-Christian Petersen [this message]
2003-08-27 7:19 ` Luca Montecchiani
2003-08-18 22:34 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308152121.44027.m.c.p@wolk-project.de \
--to=m.c.p@wolk-project.de \
--cc=davej@codemonkey.org.uk \
--cc=fxkuehl@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=mikpe@csd.uu.se \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome