* [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler
@ 2021-04-15 7:38 zhuguangqing83
2021-04-15 9:34 ` Srinivas Kandagatla
2021-04-15 18:33 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: zhuguangqing83 @ 2021-04-15 7:38 UTC (permalink / raw)
To: Srinivas Kandagatla, Banajit Goswami, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel
Cc: linux-kernel, Guangqing Zhu
From: Guangqing Zhu <zhuguangqing83@gmail.com>
Coccinelle noticed:
sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
---
sound/soc/codecs/wcd934x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
index 5fe403307b72..cddc49bbb7f6 100644
--- a/sound/soc/codecs/wcd934x.c
+++ b/sound/soc/codecs/wcd934x.c
@@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, NULL,
wcd934x_slim_irq_handler,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"slim", wcd);
if (ret) {
dev_err(dev, "Failed to request slimbus irq\n");
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler
2021-04-15 7:38 [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
@ 2021-04-15 9:34 ` Srinivas Kandagatla
2021-04-15 18:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2021-04-15 9:34 UTC (permalink / raw)
To: zhuguangqing83, Banajit Goswami, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, alsa-devel
Cc: linux-kernel
On 15/04/2021 08:38, zhuguangqing83@gmail.com wrote:
> From: Guangqing Zhu <zhuguangqing83@gmail.com>
>
> Coccinelle noticed:
> sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> ---
Thanks for the patch,
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> sound/soc/codecs/wcd934x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
> index 5fe403307b72..cddc49bbb7f6 100644
> --- a/sound/soc/codecs/wcd934x.c
> +++ b/sound/soc/codecs/wcd934x.c
> @@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)
>
> ret = devm_request_threaded_irq(dev, irq, NULL,
> wcd934x_slim_irq_handler,
> - IRQF_TRIGGER_RISING,
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> "slim", wcd);
> if (ret) {
> dev_err(dev, "Failed to request slimbus irq\n");
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler
2021-04-15 7:38 [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-15 9:34 ` Srinivas Kandagatla
@ 2021-04-15 18:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-04-15 18:33 UTC (permalink / raw)
To: Liam Girdwood, Jaroslav Kysela, Banajit Goswami,
Srinivas Kandagatla, alsa-devel, zhuguangqing83, Takashi Iwai
Cc: Mark Brown, linux-kernel
On Thu, 15 Apr 2021 15:38:29 +0800, zhuguangqing83@gmail.com wrote:
> Coccinelle noticed:
> sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler
commit: 22ff9c4230bd09ade8971c05463b90ec1d513245
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-15 18:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 7:38 [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-15 9:34 ` Srinivas Kandagatla
2021-04-15 18:33 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®