mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] ARM: tegra: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12  4:01 Zou Wei
  2021-06-01 17:04 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-05-12  4:01 UTC (permalink / raw)
  To: linux, thierry.reding, jonathanh, gustavoars
  Cc: linux-tegra, linux-kernel, Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/amba/tegra-ahb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c
index 0b2c20f..a0af8ed 100644
--- a/drivers/amba/tegra-ahb.c
+++ b/drivers/amba/tegra-ahb.c
@@ -272,6 +272,7 @@ static const struct of_device_id tegra_ahb_of_match[] = {
 	{ .compatible = "nvidia,tegra20-ahb", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, tegra_ahb_of_match);
 
 static struct platform_driver tegra_ahb_driver = {
 	.probe = tegra_ahb_probe,
-- 
2.6.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ARM: tegra: Add missing MODULE_DEVICE_TABLE
  2021-05-12  4:01 [PATCH -next] ARM: tegra: Add missing MODULE_DEVICE_TABLE Zou Wei
@ 2021-06-01 17:04 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2021-06-01 17:04 UTC (permalink / raw)
  To: Zou Wei; +Cc: linux, jonathanh, gustavoars, linux-tegra, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On Wed, May 12, 2021 at 12:01:29PM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/amba/tegra-ahb.c | 1 +
>  1 file changed, 1 insertion(+)

This driver cannot be built as an external module, so the device table
doesn't make sense.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-01 17:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12  4:01 [PATCH -next] ARM: tegra: Add missing MODULE_DEVICE_TABLE Zou Wei
2021-06-01 17:04 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®