[PATCH] xtensa: Fix duplicate included linux/unaligned/generic.h

[PATCH] xtensa: Fix duplicate included linux/unaligned/generic.h

[Jiapeng Chong]

Clean up the following includecheck warning:

./arch/xtensa/include/asm/unaligned.h: linux/unaligned/generic.h is
included more than once.

No functional change.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/xtensa/include/asm/unaligned.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/xtensa/include/asm/unaligned.h b/arch/xtensa/include/asm/unaligned.h
index 8e7ed04..c8838d9 100644
--- a/arch/xtensa/include/asm/unaligned.h
+++ b/arch/xtensa/include/asm/unaligned.h
@@ -15,15 +15,15 @@
 #ifdef __LITTLE_ENDIAN
 # include <linux/unaligned/le_struct.h>
 # include <linux/unaligned/be_byteshift.h>
-# include <linux/unaligned/generic.h>
 # define get_unaligned	__get_unaligned_le
 # define put_unaligned	__put_unaligned_le
 #else
 # include <linux/unaligned/be_struct.h>
 # include <linux/unaligned/le_byteshift.h>
-# include <linux/unaligned/generic.h>
 # define get_unaligned	__get_unaligned_be
 # define put_unaligned	__put_unaligned_be
 #endif
 
+# include <linux/unaligned/generic.h>
+
 #endif	/* _ASM_XTENSA_UNALIGNED_H */
-- 
1.8.3.1

Re: [PATCH] xtensa: Fix duplicate included linux/unaligned/generic.h

[Max Filippov]

Hi Jiapeng,

On Thu, May 13, 2021 at 4:07 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Clean up the following includecheck warning:
>
> ./arch/xtensa/include/asm/unaligned.h: linux/unaligned/generic.h is
> included more than once.
>
> No functional change.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  arch/xtensa/include/asm/unaligned.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

There's a patch series from Arnd Bergman that reworks unaligned
access posted here:
https://lore.kernel.org/lkml/20210507220813.365382-14-arnd@kernel.org/
resulting in removal of this file. I don't think it's worth doing this cleanup
in the meantime.

--
Thanks.
-- Max