mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qi Liu <liuqi115@huawei.com>
To: <alexander.shishkin@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>
Subject: [PATCH] intel_th: sth: Remove unnecessary return value
Date: Thu, 13 May 2021 21:37:04 +0800	[thread overview]
Message-ID: <1620913024-57219-1-git-send-email-liuqi115@huawei.com> (raw)

From: Junhao He <hejunhao2@hisilicon.com>

intel_th_sw_init() always return true, it's unnecessary to keep
the return value.

Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
Signed-off-by: Qi Liu <liuqi115@huawei.com>
---
 drivers/hwtracing/intel_th/sth.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/hwtracing/intel_th/sth.c b/drivers/hwtracing/intel_th/sth.c
index 9ca8c4e..5d4effd 100644
--- a/drivers/hwtracing/intel_th/sth.c
+++ b/drivers/hwtracing/intel_th/sth.c
@@ -164,7 +164,7 @@ static int sth_stm_link(struct stm_data *stm_data, unsigned int master,
 	return intel_th_set_output(to_intel_th_device(sth->dev), master);
 }
 
-static int intel_th_sw_init(struct sth_device *sth)
+static void intel_th_sw_init(struct sth_device *sth)
 {
 	u32 reg;
 
@@ -179,8 +179,6 @@ static int intel_th_sw_init(struct sth_device *sth)
 	dev_dbg(sth->dev, "sw_start: %x sw_end: %x masters: %x nchannels: %x\n",
 		sth->stm.sw_start, sth->stm.sw_end, sth->sw_nmasters,
 		sth->stm.sw_nchannels);
-
-	return 0;
 }
 
 static int intel_th_sth_probe(struct intel_th_device *thdev)
@@ -221,9 +219,7 @@ static int intel_th_sth_probe(struct intel_th_device *thdev)
 	sth->stm.sw_mmiosz = sizeof(struct intel_th_channel);
 	sth->stm.link = sth_stm_link;
 
-	err = intel_th_sw_init(sth);
-	if (err)
-		return err;
+	intel_th_sw_init(sth);
 
 	err = stm_register_device(dev, &sth->stm, THIS_MODULE);
 	if (err) {
-- 
2.8.1


                 reply	other threads:[~2021-05-13 13:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620913024-57219-1-git-send-email-liuqi115@huawei.com \
    --to=liuqi115@huawei.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®