* [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe
@ 2021-06-22 1:13 Shengjiu Wang
2021-06-22 1:44 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Shengjiu Wang @ 2021-06-22 1:13 UTC (permalink / raw)
To: timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, perex, tiwai,
alsa-devel
Cc: linuxppc-dev, linux-kernel
Don't need to print error message for defer probe
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
changes in v2:
- use dev_err_probe instead of dev_dbg
sound/soc/fsl/fsl-asoc-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index 121e08c2af2a..24c890d76da0 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -708,8 +708,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
of_node_put(framemaster);
if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
- dev_err(&pdev->dev, "failed to find codec device\n");
ret = -EPROBE_DEFER;
+ dev_err_probe(&pdev->dev, ret, "failed to find codec device\n");
goto asrc_fail;
}
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe
2021-06-22 1:13 [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe Shengjiu Wang
@ 2021-06-22 1:44 ` Fabio Estevam
2021-06-22 1:53 ` Shengjiu Wang
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2021-06-22 1:44 UTC (permalink / raw)
To: Shengjiu Wang
Cc: Timur Tabi, Nicolin Chen, Xiubo Li, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Linux-ALSA, linuxppc-dev, linux-kernel
Hi Shengjiu,
On Mon, Jun 21, 2021 at 10:31 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> Don't need to print error message for defer probe
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> changes in v2:
> - use dev_err_probe instead of dev_dbg
>
> sound/soc/fsl/fsl-asoc-card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> index 121e08c2af2a..24c890d76da0 100644
> --- a/sound/soc/fsl/fsl-asoc-card.c
> +++ b/sound/soc/fsl/fsl-asoc-card.c
> @@ -708,8 +708,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
> of_node_put(framemaster);
>
> if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
> - dev_err(&pdev->dev, "failed to find codec device\n");
> ret = -EPROBE_DEFER;
> + dev_err_probe(&pdev->dev, ret, "failed to find codec device\n");
I know I suggested dev_err_probe() before, but looking at this again, I realized
that the error message will never be printed.
Maybe the error message could just be deleted?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe
2021-06-22 1:44 ` Fabio Estevam
@ 2021-06-22 1:53 ` Shengjiu Wang
2021-06-22 2:16 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Shengjiu Wang @ 2021-06-22 1:53 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shengjiu Wang, Linux-ALSA, Timur Tabi, Xiubo Li, linux-kernel,
Takashi Iwai, Nicolin Chen, Mark Brown, linuxppc-dev
On Tue, Jun 22, 2021 at 9:45 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Shengjiu,
>
> On Mon, Jun 21, 2021 at 10:31 PM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
> >
> > Don't need to print error message for defer probe
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> > changes in v2:
> > - use dev_err_probe instead of dev_dbg
> >
> > sound/soc/fsl/fsl-asoc-card.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> > index 121e08c2af2a..24c890d76da0 100644
> > --- a/sound/soc/fsl/fsl-asoc-card.c
> > +++ b/sound/soc/fsl/fsl-asoc-card.c
> > @@ -708,8 +708,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
> > of_node_put(framemaster);
> >
> > if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
> > - dev_err(&pdev->dev, "failed to find codec device\n");
> > ret = -EPROBE_DEFER;
> > + dev_err_probe(&pdev->dev, ret, "failed to find codec device\n");
>
> I know I suggested dev_err_probe() before, but looking at this again, I realized
> that the error message will never be printed.
>
> Maybe the error message could just be deleted?
so I think we can use the v1 one, use dev_dbg instead.
best regards
wang shengjiu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe
2021-06-22 1:53 ` Shengjiu Wang
@ 2021-06-22 2:16 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2021-06-22 2:16 UTC (permalink / raw)
To: Shengjiu Wang
Cc: Shengjiu Wang, Linux-ALSA, Timur Tabi, Xiubo Li, linux-kernel,
Takashi Iwai, Nicolin Chen, Mark Brown, linuxppc-dev
On Mon, Jun 21, 2021 at 10:53 PM Shengjiu Wang <shengjiu.wang@gmail.com> wrote:
> so I think we can use the v1 one, use dev_dbg instead.
Agreed. I have just reviewed v1.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-22 2:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 1:13 [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe Shengjiu Wang
2021-06-22 1:44 ` Fabio Estevam
2021-06-22 1:53 ` Shengjiu Wang
2021-06-22 2:16 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®