From: Aaron Sierra <asierra@xes-inc.com>
To: Lee Jones <lee.jones@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Peter Tyser <ptyser@xes-inc.com>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v2] mfd: lpc_ich: Separate device cells for clarity
Date: Wed, 23 Sep 2015 09:13:19 -0500 (CDT) [thread overview]
Message-ID: <1629190950.19992.1443017599911.JavaMail.zimbra@xes-inc.com> (raw)
In-Reply-To: <20150923003119.GA16510@x1>
----- Original Message -----
> From: "Lee Jones" <lee.jones@linaro.org>
> Sent: Tuesday, September 22, 2015 7:31:19 PM
>
> On Tue, 22 Sep 2015, Aaron Sierra wrote:
>
> > The lpc_ich_cells array gives the wrong impression about the
> > relationship between the watchdog and GPIO devices. They are
> > completely distinct devices, so this patch separates the
> > array into distinct mfd_cell structs per device.
> >
> > A side effect of removing the array, is that the lpc_cells enum
> > is no longer needed.
> >
> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
> > ---
> > v2 - rebase onto 4.3-rc2
> >
> > drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------
> > 1 file changed, 18 insertions(+), 24 deletions(-)
>
> Looks like you didn't apply Andy's Ack!
Sorry, Andy! I erred on the side of caution. I wasn't sure if
the Ack applied to the concept or the iteration of the patch.
> Applied with Andy's Ack.
Thanks
-Aaron
prev parent reply other threads:[~2015-09-23 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <665163563.75615.1441306612262.JavaMail.zimbra@xes-inc.com>
2015-09-03 19:14 ` [PATCH] " Aaron Sierra
2015-09-17 16:17 ` Andy Shevchenko
2015-09-19 10:13 ` Lee Jones
2015-09-22 11:36 ` Andy Shevchenko
2015-09-19 10:16 ` Lee Jones
2015-09-21 17:37 ` Aaron Sierra
2015-09-21 23:13 ` Lee Jones
2015-09-22 22:41 ` Lee Jones
2015-09-23 0:04 ` [PATCH v2] " Aaron Sierra
2015-09-23 0:31 ` Lee Jones
2015-09-23 14:13 ` Aaron Sierra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629190950.19992.1443017599911.JavaMail.zimbra@xes-inc.com \
--to=asierra@xes-inc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt.fleming@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=ptyser@xes-inc.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome