mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <linux@armlinux.org.uk>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <hare@suse.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	John Garry <john.garry@huawei.com>
Subject: [PATCH v2 0/3] scsi: remove last references to scsi_cmnd.tag
Date: Wed, 15 Sep 2021 17:07:12 +0800	[thread overview]
Message-ID: <1631696835-136198-1-git-send-email-john.garry@huawei.com> (raw)

This is v2 of Hannes' series to fix the build errors from removing
scsi_cmnd.tag. Here is the original cover letter:

"with commit 4c7b6ea336c1 ("scsi: core: Remove scsi_cmnd.tag") drivers
cannot reference the SCSI command tag anymore.
Arguably these drivers would have stopped working since 2010 with
the switch to block layer tags in SCSI anyway, so chances are no-one
had been using tagging in these drivers.

This patchset fixes up these usage; for fas216 we're just switching
to use the appropriate wrapper.
For acornscsi the tagged queue handling is removed altogether as it
was broken in the first place, and no-one since the switch to git
could be bothered to fix it.
And the patchset has the nice side-effect that we can remove the
scsi_device.current_tag field."

AFAIK, only the arm rpc_defconfig build was broken.

I dropped the scsi_cmd_to_tag() patch as it was not strictly necessary here
and there was some doubt on its need.

The "scsi: remove 'current_tag'" patch is not needed as a fix.

Baseline is v5.15-rc1

Hannes Reinecke (3):
  fas216: kill scmd->tag
  acornscsi: remove tagged queuing vestiges
  scsi: remove 'current_tag'

 drivers/scsi/arm/Kconfig     |  11 ----
 drivers/scsi/arm/acornscsi.c | 103 ++++++++---------------------------
 drivers/scsi/arm/fas216.c    |  31 +++--------
 drivers/scsi/arm/queue.c     |   2 +-
 include/scsi/scsi_device.h   |   1 -
 5 files changed, 31 insertions(+), 117 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-09-15  9:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:07 John Garry [this message]
2021-09-15  9:07 ` [PATCH v2 1/3] fas216: kill scmd->tag John Garry
2021-09-15  9:07 ` [PATCH v2 2/3] acornscsi: remove tagged queuing vestiges John Garry
2021-09-30  7:21   ` Arnd Bergmann
2021-09-30  8:17     ` John Garry
2021-10-12 23:45     ` Bart Van Assche
2021-09-15  9:07 ` [PATCH v2 3/3] scsi: remove 'current_tag' John Garry
2021-09-16  2:52   ` Bart Van Assche
2021-09-22  4:44 ` [PATCH v2 0/3] scsi: remove last references to scsi_cmnd.tag Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1631696835-136198-1-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®