* [PATCH v3 0/3] Trivial dynamic debug fixups
@ 2021-10-13 15:40 Jason Baron
2021-10-13 15:40 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Jason Baron
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jason Baron @ 2021-10-13 15:40 UTC (permalink / raw)
To: gregkh; +Cc: ahalaney, jim.cromie, corbet, linux-doc, linux-kernel
Hi Greg,
Here's the patch series from Andrew. Please consider applying to -next.
I copied his cover letter message below.
Thanks!
-Jason
Here is round 3 of some trivial dynamic debug improvements.
v2 -> v3:
* Use a more clear example in the cli param examples
v1 -> v2:
* Use different example when showing misleading error message
* Justify dynamic debug scanning the whole command line
* Add patch removing ddebug_query
* Add patch improving cli param examples for dyndbg/$module.dyndbg
v2: https://lore.kernel.org/all/20210913222440.731329-1-ahalaney@redhat.com/
v1: https://lore.kernel.org/all/20210909161755.61743-1-ahalaney@redhat.com/
Andrew Halaney (3):
dyndbg: make dyndbg a known cli param
dyndbg: Remove support for ddebug_query param
Documentation: dyndbg: Improve cli param examples
Documentation/admin-guide/dynamic-debug-howto.rst | 13 ++++++-----
Documentation/admin-guide/kernel-parameters.txt | 5 -----
lib/dynamic_debug.c | 27 ++++++-----------------
3 files changed, 14 insertions(+), 31 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v3 1/3] dyndbg: make dyndbg a known cli param 2021-10-13 15:40 [PATCH v3 0/3] Trivial dynamic debug fixups Jason Baron @ 2021-10-13 15:40 ` Jason Baron 2021-10-13 15:40 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Jason Baron 2021-10-13 15:40 ` [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples Jason Baron 2 siblings, 0 replies; 5+ messages in thread From: Jason Baron @ 2021-10-13 15:40 UTC (permalink / raw) To: gregkh; +Cc: ahalaney, jim.cromie, corbet, linux-doc, linux-kernel From: Andrew Halaney <ahalaney@redhat.com> Right now dyndbg shows up as an unknown parameter if used on boot: Unknown command line parameters: dyndbg=+p That's because it is unknown, it doesn't sit in the __param section, so the processing done to warn users supplying an unknown parameter doesn't think it is legitimate. Install a dummy handler to register it. dynamic debug needs to search the whole command line for modules listed that are currently builtin, so there's no real work to be done in this callback. Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters") Tested-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Jason Baron <jbaron@akamai.com> --- lib/dynamic_debug.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index cb5abb42c16a..84c16309cc63 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -762,6 +762,18 @@ static __init int ddebug_setup_query(char *str) __setup("ddebug_query=", ddebug_setup_query); /* + * Install a noop handler to make dyndbg look like a normal kernel cli param. + * This avoids warnings about dyndbg being an unknown cli param when supplied + * by a user. + */ +static __init int dyndbg_setup(char *str) +{ + return 1; +} + +__setup("dyndbg=", dyndbg_setup); + +/* * File_ops->write method for <debugfs>/dynamic_debug/control. Gathers the * command text from userspace, parses and executes it. */ -- 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param 2021-10-13 15:40 [PATCH v3 0/3] Trivial dynamic debug fixups Jason Baron 2021-10-13 15:40 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Jason Baron @ 2021-10-13 15:40 ` Jason Baron 2021-10-13 15:40 ` [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples Jason Baron 2 siblings, 0 replies; 5+ messages in thread From: Jason Baron @ 2021-10-13 15:40 UTC (permalink / raw) To: gregkh; +Cc: ahalaney, jim.cromie, corbet, linux-doc, linux-kernel From: Andrew Halaney <ahalaney@redhat.com> This param has been deprecated for a very long time now, let's rip it out. Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Jason Baron <jbaron@akamai.com> --- Documentation/admin-guide/dynamic-debug-howto.rst | 6 ++---- Documentation/admin-guide/kernel-parameters.txt | 5 ----- lib/dynamic_debug.c | 25 ----------------------- 3 files changed, 2 insertions(+), 34 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index b119b8277b3e..d0911e7cc271 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -249,8 +249,7 @@ Debug messages during Boot Process To activate debug messages for core code and built-in modules during the boot process, even before userspace and debugfs exists, use -``dyndbg="QUERY"``, ``module.dyndbg="QUERY"``, or ``ddebug_query="QUERY"`` -(``ddebug_query`` is obsoleted by ``dyndbg``, and deprecated). QUERY follows +``dyndbg="QUERY"`` or ``module.dyndbg="QUERY"``. QUERY follows the syntax described above, but must not exceed 1023 characters. Your bootloader may impose lower limits. @@ -270,8 +269,7 @@ this boot parameter for debugging purposes. If ``foo`` module is not built-in, ``foo.dyndbg`` will still be processed at boot time, without effect, but will be reprocessed when module is -loaded later. ``ddebug_query=`` and bare ``dyndbg=`` are only processed at -boot. +loaded later. Bare ``dyndbg=`` is only processed at boot. Debug Messages at Module Initialization Time diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 91ba391f9b32..9c0c57d1ca78 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -841,11 +841,6 @@ Format: <port#>,<type> See also Documentation/input/devices/joystick-parport.rst - ddebug_query= [KNL,DYNAMIC_DEBUG] Enable debug messages at early boot - time. See - Documentation/admin-guide/dynamic-debug-howto.rst for - details. Deprecated, see dyndbg. - debug [KNL] Enable kernel debugging (events log level). debug_boot_weak_hash diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 84c16309cc63..130ce0eb550d 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -746,21 +746,6 @@ EXPORT_SYMBOL(__dynamic_ibdev_dbg); #endif -#define DDEBUG_STRING_SIZE 1024 -static __initdata char ddebug_setup_string[DDEBUG_STRING_SIZE]; - -static __init int ddebug_setup_query(char *str) -{ - if (strlen(str) >= DDEBUG_STRING_SIZE) { - pr_warn("ddebug boot param string too large\n"); - return 0; - } - strlcpy(ddebug_setup_string, str, DDEBUG_STRING_SIZE); - return 1; -} - -__setup("ddebug_query=", ddebug_setup_query); - /* * Install a noop handler to make dyndbg look like a normal kernel cli param. * This avoids warnings about dyndbg being an unknown cli param when supplied @@ -1133,16 +1118,6 @@ static int __init dynamic_debug_init(void) entries, modct, (int)((modct * sizeof(struct ddebug_table)) >> 10), (int)((entries * sizeof(struct _ddebug)) >> 10)); - /* apply ddebug_query boot param, dont unload tables on err */ - if (ddebug_setup_string[0] != '\0') { - pr_warn("ddebug_query param name is deprecated, change it to dyndbg\n"); - ret = ddebug_exec_queries(ddebug_setup_string, NULL); - if (ret < 0) - pr_warn("Invalid ddebug boot param %s\n", - ddebug_setup_string); - else - pr_info("%d changes by ddebug_query\n", ret); - } /* now that ddebug tables are loaded, process all boot args * again to find and activate queries given in dyndbg params. * While this has already been done for known boot params, it -- 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples 2021-10-13 15:40 [PATCH v3 0/3] Trivial dynamic debug fixups Jason Baron 2021-10-13 15:40 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Jason Baron 2021-10-13 15:40 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Jason Baron @ 2021-10-13 15:40 ` Jason Baron 2 siblings, 0 replies; 5+ messages in thread From: Jason Baron @ 2021-10-13 15:40 UTC (permalink / raw) To: gregkh; +Cc: ahalaney, jim.cromie, corbet, linux-doc, linux-kernel From: Andrew Halaney <ahalaney@redhat.com> Jim pointed out that using $module.dyndbg= is always a more flexible choice for using dynamic debug on the command line. The $module.dyndbg style is checked at boot and handles if $module is a builtin. If it is actually a loadable module, it is handled again later when the module is loaded. If you just use dyndbg="module $module +p" dynamic debug is only enabled when $module is a builtin. It was recommended to illustrate wildcard usage as well. Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Suggested-by: Jim Cromie <jim.cromie@gmail.com> Signed-off-by: Jason Baron <jbaron@akamai.com> --- Documentation/admin-guide/dynamic-debug-howto.rst | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index d0911e7cc271..ae264aab42b6 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -357,7 +357,10 @@ Examples Kernel command line: ... // see whats going on in dyndbg=value processing dynamic_debug.verbose=1 - // enable pr_debugs in 2 builtins, #cmt is stripped - dyndbg="module params +p #cmt ; module sys +p" + // enable pr_debugs in the btrfs module (can be builtin or loadable) + btrfs.dyndbg="+p" + // enable pr_debugs in all files under init/ + // and the function parse_one, #cmt is stripped + dyndbg="file init/* +p #cmt ; func parse_one +p" // enable pr_debugs in 2 functions in a module loaded later pc87360.dyndbg="func pc87360_init_device +p; func pc87360_find +p" -- 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 0/3] Trivial dynamic debug fixups @ 2021-09-20 20:54 Andrew Halaney 2021-09-20 20:54 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Andrew Halaney 0 siblings, 1 reply; 5+ messages in thread From: Andrew Halaney @ 2021-09-20 20:54 UTC (permalink / raw) To: Jason Baron, Jonathan Corbet, Jim Cromie Cc: Andrew Halaney, linux-doc, linux-kernel Hi, Here is round 3 of some trivial dynamic debug improvements. v2 -> v3: * Use a more clear example in the cli param examples v1 -> v2: * Use different example when showing misleading error message * Justify dynamic debug scanning the whole command line * Add patch removing ddebug_query * Add patch improving cli param examples for dyndbg/$module.dyndbg v2: https://lore.kernel.org/all/20210913222440.731329-1-ahalaney@redhat.com/ v1: https://lore.kernel.org/all/20210909161755.61743-1-ahalaney@redhat.com/ Andrew Halaney (3): dyndbg: make dyndbg a known cli param dyndbg: Remove support for ddebug_query param Documentation: dyndbg: Improve cli param examples .../admin-guide/dynamic-debug-howto.rst | 13 ++++----- .../admin-guide/kernel-parameters.txt | 5 ---- lib/dynamic_debug.c | 27 +++++-------------- 3 files changed, 14 insertions(+), 31 deletions(-) -- 2.31.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param 2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney @ 2021-09-20 20:54 ` Andrew Halaney 0 siblings, 0 replies; 5+ messages in thread From: Andrew Halaney @ 2021-09-20 20:54 UTC (permalink / raw) To: Jason Baron, Jonathan Corbet, Jim Cromie Cc: Andrew Halaney, linux-doc, linux-kernel This param has been deprecated for a very long time now, let's rip it out. Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- .../admin-guide/dynamic-debug-howto.rst | 6 ++--- .../admin-guide/kernel-parameters.txt | 5 ---- lib/dynamic_debug.c | 25 ------------------- 3 files changed, 2 insertions(+), 34 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index b119b8277b3e..d0911e7cc271 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -249,8 +249,7 @@ Debug messages during Boot Process To activate debug messages for core code and built-in modules during the boot process, even before userspace and debugfs exists, use -``dyndbg="QUERY"``, ``module.dyndbg="QUERY"``, or ``ddebug_query="QUERY"`` -(``ddebug_query`` is obsoleted by ``dyndbg``, and deprecated). QUERY follows +``dyndbg="QUERY"`` or ``module.dyndbg="QUERY"``. QUERY follows the syntax described above, but must not exceed 1023 characters. Your bootloader may impose lower limits. @@ -270,8 +269,7 @@ this boot parameter for debugging purposes. If ``foo`` module is not built-in, ``foo.dyndbg`` will still be processed at boot time, without effect, but will be reprocessed when module is -loaded later. ``ddebug_query=`` and bare ``dyndbg=`` are only processed at -boot. +loaded later. Bare ``dyndbg=`` is only processed at boot. Debug Messages at Module Initialization Time diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 91ba391f9b32..9c0c57d1ca78 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -841,11 +841,6 @@ Format: <port#>,<type> See also Documentation/input/devices/joystick-parport.rst - ddebug_query= [KNL,DYNAMIC_DEBUG] Enable debug messages at early boot - time. See - Documentation/admin-guide/dynamic-debug-howto.rst for - details. Deprecated, see dyndbg. - debug [KNL] Enable kernel debugging (events log level). debug_boot_weak_hash diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 84c16309cc63..130ce0eb550d 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -746,21 +746,6 @@ EXPORT_SYMBOL(__dynamic_ibdev_dbg); #endif -#define DDEBUG_STRING_SIZE 1024 -static __initdata char ddebug_setup_string[DDEBUG_STRING_SIZE]; - -static __init int ddebug_setup_query(char *str) -{ - if (strlen(str) >= DDEBUG_STRING_SIZE) { - pr_warn("ddebug boot param string too large\n"); - return 0; - } - strlcpy(ddebug_setup_string, str, DDEBUG_STRING_SIZE); - return 1; -} - -__setup("ddebug_query=", ddebug_setup_query); - /* * Install a noop handler to make dyndbg look like a normal kernel cli param. * This avoids warnings about dyndbg being an unknown cli param when supplied @@ -1133,16 +1118,6 @@ static int __init dynamic_debug_init(void) entries, modct, (int)((modct * sizeof(struct ddebug_table)) >> 10), (int)((entries * sizeof(struct _ddebug)) >> 10)); - /* apply ddebug_query boot param, dont unload tables on err */ - if (ddebug_setup_string[0] != '\0') { - pr_warn("ddebug_query param name is deprecated, change it to dyndbg\n"); - ret = ddebug_exec_queries(ddebug_setup_string, NULL); - if (ret < 0) - pr_warn("Invalid ddebug boot param %s\n", - ddebug_setup_string); - else - pr_info("%d changes by ddebug_query\n", ret); - } /* now that ddebug tables are loaded, process all boot args * again to find and activate queries given in dyndbg params. * While this has already been done for known boot params, it -- 2.31.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-13 15:42 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-13 15:40 [PATCH v3 0/3] Trivial dynamic debug fixups Jason Baron 2021-10-13 15:40 ` [PATCH v3 1/3] dyndbg: make dyndbg a known cli param Jason Baron 2021-10-13 15:40 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Jason Baron 2021-10-13 15:40 ` [PATCH v3 3/3] Documentation: dyndbg: Improve cli param examples Jason Baron -- strict thread matches above, loose matches on Subject: below -- 2021-09-20 20:54 [PATCH v3 0/3] Trivial dynamic debug fixups Andrew Halaney 2021-09-20 20:54 ` [PATCH v3 2/3] dyndbg: Remove support for ddebug_query param Andrew Halaney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®