mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] hwmon: replace snprintf in show functions with sysfs_emit
@ 2021-10-15  6:48 Qing Wang
  2021-10-15 22:00 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Qing Wang @ 2021-10-15  6:48 UTC (permalink / raw)
  To: Guenter Roeck, Jean Delvare, linux-hwmon, linux-kernel; +Cc: Qing Wang

show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
---
 drivers/hwmon/smm665.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/smm665.c b/drivers/hwmon/smm665.c
index 62906d9..122031e 100644
--- a/drivers/hwmon/smm665.c
+++ b/drivers/hwmon/smm665.c
@@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \
 { \
 	struct sensor_device_attribute *attr = to_sensor_dev_attr(da); \
 	const int val = smm665_get_##what(dev, attr->index); \
-	return snprintf(buf, PAGE_SIZE, "%d\n", val); \
+	return sysfs_emit(buf, "%d\n", val); \
 }
 
 SMM665_SHOW(min);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-15 22:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15  6:48 [PATCH] hwmon: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-15 22:00 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®