From: David Howells <dhowells@redhat.com>
To: Milosz Tanski <milosz@adfin.com>
Cc: dhowells@redhat.com, ceph-devel@vger.kernel.org,
sage@inktank.com, zheng.z.yan@intel.com,
linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fscache: check consistency does not decrement refcount
Date: Tue, 10 Sep 2013 13:34:33 +0100 [thread overview]
Message-ID: <16357.1378816473@warthog.procyon.org.uk> (raw)
In-Reply-To: <fd69f2052bc16d5a5de0104ca00ccc59478e3569.1378750714.git.milosz@adfin.com>
Milosz Tanski <milosz@adfin.com> wrote:
> __fscache_check_consistency() does not decrement the count of operations
> active after it finishes in the success case. This leads to a hung tasks on
> cookie de-registration (commonly in inode eviction).
>
> INFO: task kworker/1:2:4214 blocked for more than 120 seconds.
> kworker/1:2 D ffff880443513fc0 0 4214 2 0x00000000
> Workqueue: ceph-msgr con_work [libceph]
> ...
> Call Trace:
> [<ffffffff81569fc6>] ? _raw_spin_unlock_irqrestore+0x16/0x20
> [<ffffffffa0016570>] ? fscache_wait_bit_interruptible+0x30/0x30 [fscache]
> [<ffffffff81568d09>] schedule+0x29/0x70
> [<ffffffffa001657e>] fscache_wait_atomic_t+0xe/0x20 [fscache]
> [<ffffffff815665cf>] out_of_line_wait_on_atomic_t+0x9f/0xe0
> [<ffffffff81083560>] ? autoremove_wake_function+0x40/0x40
> [<ffffffffa0015a9c>] __fscache_relinquish_cookie+0x15c/0x310 [fscache]
> [<ffffffffa00a4fae>] ceph_fscache_unregister_inode_cookie+0x3e/0x50 [ceph]
> [<ffffffffa007e373>] ceph_destroy_inode+0x33/0x200 [ceph]
> [<ffffffff811c13ae>] ? __fsnotify_inode_delete+0xe/0x10
> [<ffffffff8119ba1c>] destroy_inode+0x3c/0x70
> [<ffffffff8119bb69>] evict+0x119/0x1b0
>
> Signed-off-by: Milosz Tanski <milosz@adfin.com>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2013-09-10 12:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 22:20 [PATCH 0/8] ceph: fscache support & upstream changes Milosz Tanski
2013-09-05 22:21 ` [PATCH 1/8] FS-Cache: Add interface to check consistency of a cached object David Howells
2013-09-05 22:21 ` [PATCH 2/8] CacheFiles: Implement interface to check cache consistency David Howells
2013-09-05 22:21 ` [PATCH 3/8] fscache: Netfs function for cleanup post readpages Milosz Tanski
2013-09-05 22:22 ` [PATCH 4/8] ceph: use fscache as a local presisent cache Milosz Tanski
2013-09-05 22:22 ` [PATCH 5/8] ceph: clean PgPrivate2 on returning from readpages Milosz Tanski
2013-09-05 22:22 ` [PATCH 6/8] ceph: ceph_readpage_to_fscache didn't check if marked Milosz Tanski
2013-09-05 22:23 ` [PATCH 7/8] ceph: page still marked private_2 Milosz Tanski
2013-09-05 22:23 ` [PATCH 8/8] ceph: Do not do invalidate if the filesystem is mounted nofsc Milosz Tanski
2013-09-05 23:00 ` [PATCH 0/8] ceph: fscache support & upstream changes Sage Weil
2013-09-06 4:41 ` Milosz Tanski
2013-09-06 15:59 ` David Howells
2013-09-06 19:02 ` Milosz Tanski
2013-09-06 20:03 ` Sage Weil
2013-09-08 3:07 ` Milosz Tanski
2013-09-08 21:21 ` Milosz Tanski
2013-09-09 10:18 ` David Howells
2013-09-09 14:53 ` Milosz Tanski
2013-09-09 17:44 ` Sage Weil
2013-09-09 18:28 ` [PATCH] fscache: check consistency does not decrement refcount Milosz Tanski
2013-09-09 18:54 ` Milosz Tanski
2013-09-10 12:34 ` David Howells [this message]
2013-09-10 16:45 ` Milosz Tanski
2013-09-10 16:48 ` Sage Weil
2013-09-09 10:17 ` [PATCH 0/8] ceph: fscache support & upstream changes David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16357.1378816473@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milosz@adfin.com \
--cc=sage@inktank.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®