From: David Howells <dhowells@redhat.com>
To: Milosz Tanski <milosz@adfin.com>
Cc: dhowells@redhat.com, Sage Weil <sage@inktank.com>,
sprabhu@redhat.com, ceph-devel <ceph-devel@vger.kernel.org>,
"Yan, Zheng" <zheng.z.yan@intel.com>,
Hongyi Jia <jiayisuse@gmail.com>,
"linux-cachefs@redhat.com" <linux-cachefs@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] ceph: fscache support & upstream changes
Date: Fri, 06 Sep 2013 16:59:02 +0100 [thread overview]
Message-ID: <18764.1378483142@warthog.procyon.org.uk> (raw)
In-Reply-To: <CANP1eJEk=eRmq1F+yYWB53spgifbU+zzKGdmKw6BGfx8SknkrA@mail.gmail.com>
Milosz Tanski <milosz@adfin.com> wrote:
> After running this for a day on some loaded machines I ran into what
> looks like an old issue with the new code. I remember you saw an issue
> that manifested it self in a similar way a while back.
>
> [13837253.462779] FS-Cache: Assertion failed
> [13837253.462782] 3 == 5 is false
> [13837253.462807] ------------[ cut here ]------------
> [13837253.462811] kernel BUG at fs/fscache/operation.c:414!
Bah.
I forgot to call fscache_op_complete(). Patch updated and repushed.
Btw, I've reordered the patches to put the CIFS patch last. Can you merge the
patches prior to the CIFS commit from my branch rather than cherry picking
them so that if they go via two different routes, GIT will handle the merge
correctly? I've stuck a tag on it (fscache-fixes-for-ceph) to make that
easier for you.
I've also asked another RH engineer to try doing some basic testing on the
CIFS stuff - which may validate the fscache_readpages_cancel patch.
David
next prev parent reply other threads:[~2013-09-06 15:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 22:20 Milosz Tanski
2013-09-05 22:21 ` [PATCH 1/8] FS-Cache: Add interface to check consistency of a cached object David Howells
2013-09-05 22:21 ` [PATCH 2/8] CacheFiles: Implement interface to check cache consistency David Howells
2013-09-05 22:21 ` [PATCH 3/8] fscache: Netfs function for cleanup post readpages Milosz Tanski
2013-09-05 22:22 ` [PATCH 4/8] ceph: use fscache as a local presisent cache Milosz Tanski
2013-09-05 22:22 ` [PATCH 5/8] ceph: clean PgPrivate2 on returning from readpages Milosz Tanski
2013-09-05 22:22 ` [PATCH 6/8] ceph: ceph_readpage_to_fscache didn't check if marked Milosz Tanski
2013-09-05 22:23 ` [PATCH 7/8] ceph: page still marked private_2 Milosz Tanski
2013-09-05 22:23 ` [PATCH 8/8] ceph: Do not do invalidate if the filesystem is mounted nofsc Milosz Tanski
2013-09-05 23:00 ` [PATCH 0/8] ceph: fscache support & upstream changes Sage Weil
2013-09-06 4:41 ` Milosz Tanski
2013-09-06 15:59 ` David Howells [this message]
2013-09-06 19:02 ` Milosz Tanski
2013-09-06 20:03 ` Sage Weil
2013-09-08 3:07 ` Milosz Tanski
2013-09-08 21:21 ` Milosz Tanski
2013-09-09 10:18 ` David Howells
2013-09-09 14:53 ` Milosz Tanski
2013-09-09 17:44 ` Sage Weil
2013-09-09 18:28 ` [PATCH] fscache: check consistency does not decrement refcount Milosz Tanski
2013-09-09 18:54 ` Milosz Tanski
2013-09-10 12:34 ` David Howells
2013-09-10 16:45 ` Milosz Tanski
2013-09-10 16:48 ` Sage Weil
2013-09-09 10:17 ` [PATCH 0/8] ceph: fscache support & upstream changes David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18764.1378483142@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jiayisuse@gmail.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milosz@adfin.com \
--cc=sage@inktank.com \
--cc=sprabhu@redhat.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®