From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
<tiwai@suse.com>
Cc: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH 4/4] ASoC: tegra: Fix kcontrol put callback in DSPK
Date: Wed, 3 Nov 2021 10:34:57 +0530 [thread overview]
Message-ID: <1635915897-32313-5-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1635915897-32313-1-git-send-email-spujar@nvidia.com>
The kcontrol put callback is expected to return 1 when there is change
in HW or when the update is acknowledged by driver. This would ensure
that change notifications are sent to subscribed applications. Update
the DSPK driver accordingly.
Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver")
Suggested-by: Jaroslav Kysela <perex@perex.cz>
Suggested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
sound/soc/tegra/tegra186_dspk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dspk.c
index 8ee9a77..3b1bdb7 100644
--- a/sound/soc/tegra/tegra186_dspk.c
+++ b/sound/soc/tegra/tegra186_dspk.c
@@ -67,8 +67,10 @@ static int tegra186_dspk_put_control(struct snd_kcontrol *kcontrol,
dspk->mono_to_stereo = val;
else if (strstr(kcontrol->id.name, "Stereo To Mono"))
dspk->stereo_to_mono = val;
+ else
+ return 0;
- return 0;
+ return 1;
}
static int __maybe_unused tegra186_dspk_runtime_suspend(struct device *dev)
--
2.7.4
next prev parent reply other threads:[~2021-11-03 5:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 5:04 [PATCH 0/4] Fix kcontrol put callback in Tegra drivers Sameer Pujar
2021-11-03 5:04 ` [PATCH 1/4] ASoC: tegra: Fix kcontrol put callback in ADMAIF Sameer Pujar
2021-11-03 5:04 ` [PATCH 2/4] ASoC: tegra: Fix kcontrol put callback in I2S Sameer Pujar
2021-11-03 5:04 ` [PATCH 3/4] ASoC: tegra: Fix kcontrol put callback in DMIC Sameer Pujar
2021-11-03 5:04 ` Sameer Pujar [this message]
2021-11-03 8:50 ` [PATCH 0/4] Fix kcontrol put callback in Tegra drivers Jaroslav Kysela
2021-11-03 11:29 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1635915897-32313-5-git-send-email-spujar@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®