From: Sameer Pujar <spujar@nvidia.com>
To: Jaroslav Kysela <perex@perex.cz>,
broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.com
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix kcontrol put callback in Tegra drivers
Date: Wed, 3 Nov 2021 16:59:08 +0530 [thread overview]
Message-ID: <1b63798e-cf3f-5ef8-1950-3111273ad82d@nvidia.com> (raw)
In-Reply-To: <8a00ea68-4859-fbcc-6292-909a66b0a188@perex.cz>
On 11/3/2021 2:20 PM, Jaroslav Kysela wrote:
> External email: Use caution opening links or attachments
>
>
> On 03. 11. 21 6:04, Sameer Pujar wrote:
>> This series fixes kcontrol put callback in some of the Tegra drivers
>> which are used on platforms based on Tegra210 and later. The callback
>> is expected to return 1 whenever the HW update is done.
>
> The logic is a little bit another. The 1 means change, so you should
> compare
> the register / cached value and return 1 only when a different value
> is set.
> Your implementation invokes the change events for duplicate updates.
Sorry, I did not think the about duplicate updates. Thanks for the
suggestion.
prev parent reply other threads:[~2021-11-03 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 5:04 Sameer Pujar
2021-11-03 5:04 ` [PATCH 1/4] ASoC: tegra: Fix kcontrol put callback in ADMAIF Sameer Pujar
2021-11-03 5:04 ` [PATCH 2/4] ASoC: tegra: Fix kcontrol put callback in I2S Sameer Pujar
2021-11-03 5:04 ` [PATCH 3/4] ASoC: tegra: Fix kcontrol put callback in DMIC Sameer Pujar
2021-11-03 5:04 ` [PATCH 4/4] ASoC: tegra: Fix kcontrol put callback in DSPK Sameer Pujar
2021-11-03 8:50 ` [PATCH 0/4] Fix kcontrol put callback in Tegra drivers Jaroslav Kysela
2021-11-03 11:29 ` Sameer Pujar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b63798e-cf3f-5ef8-1950-3111273ad82d@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®