From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
Cc: linux-pm@vger.kernel.org, daniel.lezcano@linaro.org,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] cpuidle: fix permission for driver name sysfs node
Date: Wed, 23 Jul 2014 01:54:35 +0200 [thread overview]
Message-ID: <1636314.JDKxdToLsi@vostro.rjw.lan> (raw)
In-Reply-To: <1405171762-31119-1-git-send-email-meraj.enigma@gmail.com>
On Saturday, July 12, 2014 07:29:22 PM Mohammad Merajul Islam Molla wrote:
> cpuidle driver name sysfs node is read-only. So permission should be 0444.
>
> Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
Queued up for 3.17, thanks!
> ---
> drivers/cpuidle/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index efe2f17..97c5903 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
>
> #define define_one_driver_ro(_name, show) \
> static struct cpuidle_driver_attr attr_driver_##_name = \
> - __ATTR(_name, 0644, show, NULL)
> + __ATTR(_name, 0444, show, NULL)
>
> struct cpuidle_driver_kobj {
> struct cpuidle_driver *drv;
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-07-22 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 13:29 Mohammad Merajul Islam Molla
2014-07-15 5:16 ` Mohammad Merajul Islam Molla
2014-07-15 12:28 ` Rafael J. Wysocki
2014-07-15 13:24 ` Mohammad Merajul Islam Molla
2014-07-22 23:54 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636314.JDKxdToLsi@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=meraj.enigma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®