Re: [PATCH] cpuidle: fix permission for driver name sysfs node

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Tuesday, July 15, 2014 11:16:40 AM Mohammad Merajul Islam Molla wrote:
> Hi Rafael/Daniel,
> 
> Did you get a chance to review the patch?

We will review it.  Why is this urgent?

Rafael


> On Sat, Jul 12, 2014 at 7:29 PM, Mohammad Merajul Islam Molla
> <meraj.enigma@gmail.com> wrote:
> > cpuidle driver name sysfs node is read-only. So permission should be 0444.
> >
> > Signed-off-by: Mohammad Merajul Islam Molla <meraj.enigma@gmail.com>
> > ---
> >  drivers/cpuidle/sysfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> > index efe2f17..97c5903 100644
> > --- a/drivers/cpuidle/sysfs.c
> > +++ b/drivers/cpuidle/sysfs.c
> > @@ -445,7 +445,7 @@ static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
> >
> >  #define define_one_driver_ro(_name, show)                       \
> >         static struct cpuidle_driver_attr attr_driver_##_name = \
> > -               __ATTR(_name, 0644, show, NULL)
> > +               __ATTR(_name, 0444, show, NULL)
> >
> >  struct cpuidle_driver_kobj {
> >         struct cpuidle_driver *drv;
> > --
> > 1.9.1
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.