From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Pavel Machek <pavel@ucw.cz>,
Tomas Winkler <tomas.winkler@intel.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain
Date: Fri, 08 Jan 2016 01:20:08 +0100 [thread overview]
Message-ID: <1638223.v1Ed2MLOOC@vostro.rjw.lan> (raw)
In-Reply-To: <CAAObsKC1jTzLWmMtwGWVStuMtzZwvMuA_731dsn4YX7aKMtFKQ@mail.gmail.com>
On Thursday, January 07, 2016 03:47:01 PM Tomeu Vizoso wrote:
> On 10 November 2015 at 10:33, Daniel Kurtz <djkurtz@chromium.org> wrote:
> [snip]
> >
> > The problem appears to be that:
> > * On boot, platform_drv_probe() calls dev_pm_domain_attach() before
> > drv->probe(); thus, it calls dev_pm_domain_attach() while the device
> > is unbound.
> >
> > * However, for a platform_device, the reboot path calls
> > device_shutdown(), but not __device_release_driver():
> > device_shutdown()
> > dev->driver->shutdown => platform_drv_shutdown()
> > dev_pm_domain_detach()
> > dev->pm_domain->detach() => genpd_dev_pm_detach()
> > pm_genpd_remove_device()
> > dev_pm_domain_set(dev, NULL);
> >
> > So, for a platform_device in a genpd power domain with .shutdown
> > installed, platform_drv_shutdown() calls dev_pm_domain_detach() while
> > the device is still bound, which triggers the WARN().
>
> Hi Rafael, Alan and Ulf,
>
> do you have any suggestion about this? I don't really understand why
> the device is detached from the domain on shutdown.
Well, this looks like a bug to me.
Thanks,
Rafael
next prev parent reply other threads:[~2016-01-07 23:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 14:38 [PATCH v11 0/4] Allow USB devices to remain runtime-suspended when sleeping Tomeu Vizoso
2015-10-27 14:38 ` [PATCH v11 1/4] device core: add device_is_bound() Tomeu Vizoso
2015-10-27 14:38 ` [PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain Tomeu Vizoso
2015-11-10 9:33 ` Daniel Kurtz
2016-01-07 14:47 ` Tomeu Vizoso
2016-01-08 0:20 ` Rafael J. Wysocki [this message]
2016-01-11 14:35 ` Fabio Estevam
2016-01-11 14:45 ` Rafael J. Wysocki
2016-01-11 14:52 ` Fabio Estevam
2016-01-11 21:09 ` Ulf Hansson
2015-10-27 14:38 ` [PATCH v11 3/4] PM / sleep: Go direct_complete if driver has no callbacks Tomeu Vizoso
2015-10-27 14:38 ` [PATCH v11 4/4] USB / PM: Allow USB devices to remain runtime-suspended when sleeping Tomeu Vizoso
2015-11-02 1:50 ` [PATCH v11 0/4] " Rafael J. Wysocki
2016-01-05 2:27 ` Derek Basehore
2016-01-05 12:48 ` Rafael J. Wysocki
2016-01-05 23:38 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638223.v1Ed2MLOOC@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pavel@ucw.cz \
--cc=stern@rowland.harvard.edu \
--cc=tomas.winkler@intel.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome