From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wenst@chromium.org,
kernel@collabora.com, ehristev@collabora.com
Subject: Re: [PATCH v11 08/16] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions
Date: Thu, 12 Oct 2023 15:17:46 -0400 [thread overview]
Message-ID: <1638da95-fd9c-4557-91d9-92bf1b54feaf@notapiano> (raw)
In-Reply-To: <20231012095736.100784-9-angelogioacchino.delregno@collabora.com>
On Thu, Oct 12, 2023 at 11:57:28AM +0200, AngeloGioacchino Del Regno wrote:
> In preparation for adding a 12-bits gamma support for the DISP_GAMMA
> IP, remove the mtk_gamma_set_common() function and move the relevant
> bits in mtk_gamma_set() for DISP_GAMMA and mtk_aal_gamma_set() for
> DISP_AAL: since the latter has no more support for gamma manipulation
> (being moved to a different IP) in newer revisions, those functions
> are about to diverge and it makes no sense to keep a common one (with
> all the complications of passing common data and making exclusions
> for device driver data) for just a few bits.
>
> This commit brings no functional changes.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Thanks,
Nícolas
next prev parent reply other threads:[~2023-10-12 19:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 9:57 [PATCH v11 00/16] MediaTek DDP GAMMA - 12-bit LUT support AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 01/16] drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 02/16] drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common() AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 03/16] drm/mediatek: gamma: Support SoC specific LUT size AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 04/16] drm/mediatek: gamma: Improve and simplify HW LUT calculation AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 05/16] drm/mediatek: gamma: Enable the Gamma LUT table only after programming AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 06/16] drm/mediatek: gamma: Use bitfield macros AngeloGioacchino Del Regno
2023-10-13 4:00 ` CK Hu (胡俊光)
2023-10-16 7:55 ` AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 07/16] drm/mediatek: aal: " AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 08/16] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions AngeloGioacchino Del Regno
2023-10-12 19:17 ` Nícolas F. R. A. Prado [this message]
2023-10-13 4:07 ` CK Hu (胡俊光)
2023-10-25 10:43 ` AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 09/16] drm/mediatek: gamma: Support multi-bank gamma LUT AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 10/16] drm/mediatek: gamma: Add support for 12-bit LUT AngeloGioacchino Del Regno
2023-10-13 4:18 ` CK Hu (胡俊光)
2023-10-12 9:57 ` [PATCH v11 11/16] drm/mediatek: gamma: Add support for MT8195 AngeloGioacchino Del Regno
2023-10-13 4:21 ` CK Hu (胡俊光)
2023-10-12 9:57 ` [PATCH v11 12/16] drm/mediatek: gamma: Make sure relay mode is disabled AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 13/16] drm/mediatek: gamma: Program gamma LUT type for descending or rising AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 14/16] drm/mediatek: aal: Add kerneldoc for struct mtk_disp_aal AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 15/16] drm/mediatek: gamma: Add kerneldoc for struct mtk_disp_gamma AngeloGioacchino Del Regno
2023-10-12 9:57 ` [PATCH v11 16/16] drm/mediatek: aal: Compress of_device_id entries and add sentinel AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638da95-fd9c-4557-91d9-92bf1b54feaf@notapiano \
--to=nfraprado@collabora.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ehristev@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®