From: Kalle Valo <kvalo@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: remove redundant initialization of variable ul_encalgo
Date: Tue, 1 Feb 2022 12:26:41 +0000 (UTC) [thread overview]
Message-ID: <164371839993.16633.14924668742063969395.kvalo@kernel.org> (raw)
In-Reply-To: <20220130223714.6999-1-colin.i.king@gmail.com>
Colin Ian King <colin.i.king@gmail.com> wrote:
> Variable ul_encalgo is initialized with a value that is never read,
> it is being re-assigned a new value in every case in the following
> switch statement. The initialization is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
e80affde1720 rtlwifi: remove redundant initialization of variable ul_encalgo
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220130223714.6999-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-02-01 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 22:37 Colin Ian King
2022-01-31 2:53 ` Pkshih
2022-02-01 12:22 ` Kalle Valo
2022-02-02 5:02 ` Dan Carpenter
2022-02-02 10:10 ` Joe Perches
2022-02-02 11:05 ` Dan Carpenter
2022-02-02 11:21 ` Joe Perches
2022-02-02 11:44 ` Dan Carpenter
2022-02-01 12:26 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164371839993.16633.14924668742063969395.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®