From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, Pkshih <pkshih@realtek.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"colin.i.king@gmail.com" <colin.i.king@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove redundant initialization of variable ul_encalgo
Date: Wed, 02 Feb 2022 02:10:40 -0800 [thread overview]
Message-ID: <90e40bb19320dcc2f2099b97b4b9d7d23325eaac.camel@perches.com> (raw)
In-Reply-To: <20220202050229.GS1951@kadam>
On Wed, 2022-02-02 at 08:02 +0300, Dan Carpenter wrote:
> On Mon, Jan 31, 2022 at 02:53:40AM +0000, Pkshih wrote:
> > On Sun, 2022-01-30 at 22:37 +0000, Colin Ian King wrote:
> >
> > When I check this patch, I find there is no 'break' for default case.
> > Do we need one? like
> >
> > @@ -226,6 +226,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
> > break;
> > default:
> > ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES];
> > + break;
>
> No, it's not necessary. The choice of style is up to the original
> developer.
every case should have one.
Documentation/process/deprecated.rst:
All switch/case blocks must end in one of:
* break;
* fallthrough;
* continue;
* goto <label>;
* return [expression];
next prev parent reply other threads:[~2022-02-02 10:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 22:37 Colin Ian King
2022-01-31 2:53 ` Pkshih
2022-02-01 12:22 ` Kalle Valo
2022-02-02 5:02 ` Dan Carpenter
2022-02-02 10:10 ` Joe Perches [this message]
2022-02-02 11:05 ` Dan Carpenter
2022-02-02 11:21 ` Joe Perches
2022-02-02 11:44 ` Dan Carpenter
2022-02-01 12:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e40bb19320dcc2f2099b97b4b9d7d23325eaac.camel@perches.com \
--to=joe@perches.com \
--cc=colin.i.king@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®