* [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC
@ 2022-02-11 6:51 Gatis Peisenieks
2022-02-11 22:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 4+ messages in thread
From: Gatis Peisenieks @ 2022-02-11 6:51 UTC (permalink / raw)
To: chris.snook, davem, kuba, hkallweit1, jesse.brandeburg,
dchickles, tully, antons, eric.dumazet
Cc: netdev, linux-kernel, Gatis Peisenieks
If NIC had packets in tx queue at the moment link down event
happened, it could result in tx timeout when link got back up.
Since device has more than one tx queue we need to reset them
accordingly.
Fixes: 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC")
Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index da595242bc13..f50604f3e541 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -900,7 +900,7 @@ static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter,
atl1c_clean_buffer(pdev, buffer_info);
}
- netdev_reset_queue(adapter->netdev);
+ netdev_tx_reset_queue(netdev_get_tx_queue(adapter->netdev, queue));
/* Zero out Tx-buffers */
memset(tpd_ring->desc, 0, sizeof(struct atl1c_tpd_desc) *
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC
2022-02-11 6:51 [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC Gatis Peisenieks
@ 2022-02-11 22:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-11 22:50 UTC (permalink / raw)
To: Gatis Peisenieks
Cc: chris.snook, davem, kuba, hkallweit1, jesse.brandeburg,
dchickles, tully, antons, eric.dumazet, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 11 Feb 2022 08:51:23 +0200 you wrote:
> If NIC had packets in tx queue at the moment link down event
> happened, it could result in tx timeout when link got back up.
>
> Since device has more than one tx queue we need to reset them
> accordingly.
>
> Fixes: 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC")
> Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
>
> [...]
Here is the summary with links:
- [net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC
https://git.kernel.org/netdev/net/c/bf8e59fd315f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC
@ 2022-02-10 8:12 Gatis Peisenieks
2022-02-11 2:20 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Gatis Peisenieks @ 2022-02-10 8:12 UTC (permalink / raw)
To: chris.snook, davem, kuba, hkallweit1, jesse.brandeburg,
dchickles, tully, antons, eric.dumazet
Cc: netdev, linux-kernel, Gatis Peisenieks
If NIC had packets in tx queue at the moment link down event
happened, it could result in tx timeout when link got back up.
Since device has more than one tx queue we need to reset them
accordingly.
Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index da595242bc13..f50604f3e541 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -900,7 +900,7 @@ static void atl1c_clean_tx_ring(struct atl1c_adapter *adapter,
atl1c_clean_buffer(pdev, buffer_info);
}
- netdev_reset_queue(adapter->netdev);
+ netdev_tx_reset_queue(netdev_get_tx_queue(adapter->netdev, queue));
/* Zero out Tx-buffers */
memset(tpd_ring->desc, 0, sizeof(struct atl1c_tpd_desc) *
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC
2022-02-10 8:12 Gatis Peisenieks
@ 2022-02-11 2:20 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-02-11 2:20 UTC (permalink / raw)
To: Gatis Peisenieks
Cc: chris.snook, davem, hkallweit1, jesse.brandeburg, dchickles,
tully, antons, eric.dumazet, netdev, linux-kernel
On Thu, 10 Feb 2022 10:12:01 +0200 Gatis Peisenieks wrote:
> If NIC had packets in tx queue at the moment link down event
> happened, it could result in tx timeout when link got back up.
>
> Since device has more than one tx queue we need to reset them
> accordingly.
>
> Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
Fixes: 057f4af2b171 ("atl1c: add 4 RX/TX queue support for Mikrotik 10/25G NIC")
?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-11 22:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-11 6:51 [PATCH net] atl1c: fix tx timeout after link flap on Mikrotik 10/25G NIC Gatis Peisenieks
2022-02-11 22:50 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-02-10 8:12 Gatis Peisenieks
2022-02-11 2:20 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®