* [PATCH v3 1/3] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk
2022-03-03 8:08 [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates Vinod Polimera
@ 2022-03-03 8:08 ` Vinod Polimera
2022-03-03 8:08 ` [PATCH v3 2/3] arm64/dts/qcom/sc7180: " Vinod Polimera
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Polimera @ 2022-03-03 8:08 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Vinod Polimera, linux-kernel, robdclark, dianders, swboyd, quic_kalyant
Kernel clock driver assumes that initial rate is the
max rate for that clock and was not allowing it to scale
beyond the assigned clock value.
Drop the assigned clock rate property and vote on the mdp clock as per
calculated value during the usecase.
Changes in v2:
- Remove assigned-clock-rate property and set mdp clk during resume sequence.
- Add fixes tag.
Changes in v3:
- Remove extra line after fixes tag.(Stephen Boyd)
- Add similar changes for sc7180, sdm845 which uses opp table for voting mdp clk.(Stephen Boyd)
- Drop patch: "drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table"
Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes")
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index baf1653..408cf6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2856,9 +2856,6 @@
"ahb",
"core";
- assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
- assigned-clock-rates = <300000000>;
-
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <1>;
@@ -2892,11 +2889,9 @@
"lut",
"core",
"vsync";
- assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
- <&dispcc DISP_CC_MDSS_VSYNC_CLK>,
+ assigned-clocks = <&dispcc DISP_CC_MDSS_VSYNC_CLK>,
<&dispcc DISP_CC_MDSS_AHB_CLK>;
- assigned-clock-rates = <300000000>,
- <19200000>,
+ assigned-clock-rates = <19200000>,
<19200000>;
operating-points-v2 = <&mdp_opp_table>;
power-domains = <&rpmhpd SC7280_CX>;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v3 2/3] arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk
2022-03-03 8:08 [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates Vinod Polimera
2022-03-03 8:08 ` [PATCH v3 1/3] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk Vinod Polimera
@ 2022-03-03 8:08 ` Vinod Polimera
2022-03-03 8:08 ` [PATCH v3 3/3] arm64/dts/qcom/sdm845: " Vinod Polimera
2022-03-03 8:19 ` [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates Dmitry Baryshkov
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Polimera @ 2022-03-03 8:08 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Vinod Polimera, linux-kernel, robdclark, dianders, swboyd, quic_kalyant
Kernel clock driver assumes that initial rate is the
max rate for that clock and was not allowing it to scale
beyond the assigned clock value.
Drop the assigned clock rate property and vote on the mdp clock as per
calculated value during the usecase.
Fixes: a3db7ad1af("arm64: dts: qcom: sc7180: add display dt nodes")
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index e1c46b8..eaab746 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2900,9 +2900,6 @@
<&dispcc DISP_CC_MDSS_MDP_CLK>;
clock-names = "iface", "ahb", "core";
- assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
- assigned-clock-rates = <300000000>;
-
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <1>;
@@ -2932,12 +2929,10 @@
<&dispcc DISP_CC_MDSS_VSYNC_CLK>;
clock-names = "bus", "iface", "rot", "lut", "core",
"vsync";
- assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
- <&dispcc DISP_CC_MDSS_VSYNC_CLK>,
+ assigned-clocks = <&dispcc DISP_CC_MDSS_VSYNC_CLK>,
<&dispcc DISP_CC_MDSS_ROT_CLK>,
<&dispcc DISP_CC_MDSS_AHB_CLK>;
- assigned-clock-rates = <300000000>,
- <19200000>,
+ assigned-clock-rates = <19200000>,
<19200000>,
<19200000>;
operating-points-v2 = <&mdp_opp_table>;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v3 3/3] arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk
2022-03-03 8:08 [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates Vinod Polimera
2022-03-03 8:08 ` [PATCH v3 1/3] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk Vinod Polimera
2022-03-03 8:08 ` [PATCH v3 2/3] arm64/dts/qcom/sc7180: " Vinod Polimera
@ 2022-03-03 8:08 ` Vinod Polimera
2022-03-03 8:19 ` [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates Dmitry Baryshkov
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Polimera @ 2022-03-03 8:08 UTC (permalink / raw)
To: dri-devel, linux-arm-msm, freedreno, devicetree
Cc: Vinod Polimera, linux-kernel, robdclark, dianders, swboyd, quic_kalyant
Kernel clock driver assumes that initial rate is the
max rate for that clock and was not allowing it to scale
beyond the assigned clock value.
Drop the assigned clock rate property and vote on the mdp clock as per
calculated value during the usecase.
Fixes: 08c2a076d1("arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file")
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 0d6286d..80dc486 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4181,9 +4181,6 @@
<&dispcc DISP_CC_MDSS_MDP_CLK>;
clock-names = "iface", "core";
- assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
- assigned-clock-rates = <300000000>;
-
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <1>;
@@ -4214,10 +4211,8 @@
<&dispcc DISP_CC_MDSS_VSYNC_CLK>;
clock-names = "gcc-bus", "iface", "bus", "core", "vsync";
- assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
- <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
- assigned-clock-rates = <300000000>,
- <19200000>;
+ assigned-clocks = <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
+ assigned-clock-rates = <19200000>;
operating-points-v2 = <&mdp_opp_table>;
power-domains = <&rpmhpd SDM845_CX>;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates
2022-03-03 8:08 [PATCH v3 0/3] Update mdp clk to max supported value to support higher refresh rates Vinod Polimera
` (2 preceding siblings ...)
2022-03-03 8:08 ` [PATCH v3 3/3] arm64/dts/qcom/sdm845: " Vinod Polimera
@ 2022-03-03 8:19 ` Dmitry Baryshkov
3 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2022-03-03 8:19 UTC (permalink / raw)
To: Vinod Polimera
Cc: dri-devel, linux-arm-msm, freedreno, devicetree, linux-kernel,
robdclark, dianders, swboyd, quic_kalyant
On Thu, 3 Mar 2022 at 11:08, Vinod Polimera <quic_vpolimer@quicinc.com> wrote:
>
> *** BLURB HERE ***
Description, dependencies, etc?
>
> Vinod Polimera (3):
> arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk
> arm64/dts/qcom/sc7180: remove assigned-clock-rate property for mdp clk
> arm64/dts/qcom/sdm845: remove assigned-clock-rate property for mdp clk
sm8250.dtsi is missing
>
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 ++-------
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 ++-------
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 ++-------
> 3 files changed, 6 insertions(+), 21 deletions(-)
>
> --
> 2.7.4
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread